Bug 150145 - [iOS] QuickLook documents loaded over https do not load their subresources
Summary: [iOS] QuickLook documents loaded over https do not load their subresources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad All
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-14 15:02 PDT by Andy Estes
Modified: 2015-10-14 17:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (349.93 KB, patch)
2015-10-14 15:34 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (1.00 MB, application/zip)
2015-10-14 15:49 PDT, Build Bot
no flags Details
Patch (351.17 KB, patch)
2015-10-14 15:52 PDT, Andy Estes
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-10-14 15:02:55 PDT
[iOS] QuickLook documents loaded over https do not load their subresources
Comment 1 Andy Estes 2015-10-14 15:27:18 PDT
<rdar://problem/22884521>
Comment 2 Andy Estes 2015-10-14 15:34:44 PDT
Created attachment 263116 [details]
Patch
Comment 3 Build Bot 2015-10-14 15:49:45 PDT
Comment on attachment 263116 [details]
Patch

Attachment 263116 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/288292

New failing tests:
http/tests/quicklook/secure-document-with-subresources.html
Comment 4 Build Bot 2015-10-14 15:49:47 PDT
Created attachment 263117 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Andy Estes 2015-10-14 15:52:33 PDT
Created attachment 263119 [details]
Patch
Comment 6 Alexey Proskuryakov 2015-10-14 17:18:13 PDT
Comment on attachment 263119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263119&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::secureSchemes): Registered QLPreviewProtocol() as a secure scheme.

What a scary name. I can see how everyone looking at it will have a different idea of what it means to be secure.

Not a new problem with this patch.
Comment 7 Andy Estes 2015-10-14 17:22:01 PDT
Committed r191076: <http://trac.webkit.org/changeset/191076>