Bug 150127 - Rename some JSC option names to be more uniform.
Summary: Rename some JSC option names to be more uniform.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 10:52 PDT by Mark Lam
Modified: 2015-10-14 11:58 PDT (History)
8 users (show)

See Also:

Attachments
the patch. (75.68 KB, patch)
2015-10-14 11:08 PDT, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-10-14 10:52:10 PDT 
Will rename JSC_enableXXX options to JSC_useXXX, and JSC_showXXX options to JSC_dumpXXX.  Also will rename a few other miscellaneous to options, to abide by this scheme.

Also will rename some functions to match the option names where relevant.
Comment 1 Mark Lam 2015-10-14 11:08:48 PDT 
Created attachment 263088 [details]
the patch.
Comment 2 WebKit Commit Bot 2015-10-14 11:12:03 PDT 
Attachment 263088 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:328:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:331:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:350:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:353:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/Options.h:136:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-10-14 11:53:55 PDT 
Comment on attachment 263088 [details]
the patch.

r=me
Comment 4 Mark Lam 2015-10-14 11:58:23 PDT 
Thanks.  Landed in r191058: <http://trac.webkit.org/r191058>.