Bug 150126 - [WIN] Layout Test fast/dynamic/insert-before-table-part-in-continuation.html is failing
Summary: [WIN] Layout Test fast/dynamic/insert-before-table-part-in-continuation.html ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 10:49 PDT by Ryan Haddad
Modified: 2015-10-20 13:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2015-10-19 10:51 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (21.60 KB, patch)
2015-10-19 11:06 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2015-10-20 13:00 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2015-10-14 10:49:53 PDT 
The following layout test is failing on Windows and GTK after http://trac.webkit.org/changeset/191011

fast/dynamic/insert-before-table-part-in-continuation.html
Comment 2 Ryan Haddad 2015-10-19 10:51:40 PDT 
Created attachment 263490 [details]
Patch

Marking test as flaky on win
Comment 3 zalan 2015-10-19 11:01:31 PDT 
Comment on attachment 263490 [details]
Patch

It needs rebaselining on Win (r191011 has the updated expected result only for mac)
Comment 4 Ryan Haddad 2015-10-19 11:06:54 PDT 
Created attachment 263492 [details]
Patch

Here is a patch with an updated expectation file for win.
Comment 5 WebKit Commit Bot 2015-10-19 12:12:26 PDT 
Comment on attachment 263492 [details]
Patch

Clearing flags on attachment: 263492

Committed r191304: <http://trac.webkit.org/changeset/191304>
Comment 6 WebKit Commit Bot 2015-10-19 12:12:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Ryan Haddad 2015-10-20 12:58:13 PDT 
Still failing due to lack of newline at the end of file.. I'm not sure why this is happening.

--- /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
+++ /home/buildbot/slave/win-release-tests/build/layout-test-results/fast/dynamic/insert-before-table-part-in-continuation-actual.txt
@@ -204,4 +204,4 @@
                 RenderTableRow (anonymous) at (0,0) size 103x18
                   RenderTableCell (anonymous) at (0,0) size 103x18 [r=0 c=0 rs=1 cs=1]
                     RenderText {#text} at (0,0) size 103x18
-                      text run at (0,0) width 103: "...continues here"
\ No newline at end of file
+                      text run at (0,0) width 103: "...continues here"
Comment 8 Ryan Haddad 2015-10-20 13:00:10 PDT 
Created attachment 263603 [details]
Patch

New patch with newline at end of file
Comment 9 WebKit Commit Bot 2015-10-20 13:55:09 PDT 
Comment on attachment 263603 [details]
Patch

Clearing flags on attachment: 263603

Committed r191356: <http://trac.webkit.org/changeset/191356>
Comment 10 WebKit Commit Bot 2015-10-20 13:55:12 PDT 
All reviewed patches have been landed.  Closing bug.