RESOLVED WONTFIX 150119
[WinCairo] Fix incremental build issue revealed by r191017 
https://bugs.webkit.org/show_bug.cgi?id=150119
Summary [WinCairo] Fix incremental build issue revealed by r191017
Csaba Osztrogonác
Reported 2015-10-14 04:52:02 PDT
https://trac.webkit.org/changeset/191017 added a new header file - WTF/wtf/PointerComparison.h and added includes of this new header file to many cpp files. But the incremental build failed: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/50106 c:\users\alex\documents\wincairobot\win-cairo-release\build\source\webcore\rendering\style\FillLayer.cpp(25): fatal error C1083: Cannot open include file: 'wtf/PointerComparison.h': No such file or directory ... ... but the clean build feature is broken on the WinCairo bot, see bug149625 for details.
Attachments
Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-10-14 12:18:01 PDT
PointerComparison.h should have been added to WTF_HEADERS, and CMake would have been run again, and the header would've been copied. EWS must have been doing a clean build, because it passed. I'm not sure what to do about this.
Csaba Osztrogonác
Comment 2 2015-10-14 12:28:48 PDT
(In reply to comment #1) > PointerComparison.h should have been added to WTF_HEADERS, and CMake would > have been run again, and the header would've been copied. EWS must have > been doing a clean build, because it passed. I'm not sure what to do about > this. Why should we add each header files to the cmake project? And what is this copying? Is it something WinCairo specific? Linux ports and Apple Windows port don't need it at all. Can we make the WinCairo build happier without adding each header file to the build system?
Csaba Osztrogonác
Comment 3 2016-02-15 23:39:40 PST
It seems nobody fixes it.
Note You need to log in before you can comment on or make changes to this bug.