Bug 150106 – _WKThumbnailView should support a snapshot-only mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Conrad Shultz]

Currently _WKThumbnailView works by reparenting the layer tree of the associated WKView, then snapshotting it.

It would be helpful to have a mode where it can simply snapshot the WKView without impacting the layer tree or blocking interaction with the WKView.

[Radar WebKit Bug Importer]

<rdar://problem/23099438>

[Conrad Shultz]

Created attachment 263105 [details]
Patch

[Tim Horton]

Comment on attachment 263105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263105&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.h:42
> +@property (nonatomic) BOOL exclusivelyUsesSnapshot;

I don't know if this is how we should word this, because if e.g. we managed to have a layer tree in two places at once, or something crazy like that, we could get the behavior you want (WKView left undisturbed) without sacrificing the instantaneous-ness/no-flashyness of WKThumbnailView.

Maybe it should be about the difference in the WKView's behavior?

[Conrad Shultz]

(In reply to comment #3)
> Comment on attachment 263105 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263105&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKThumbnailView.h:42
> > +@property (nonatomic) BOOL exclusivelyUsesSnapshot;
> 
> I don't know if this is how we should word this, because if e.g. we managed
> to have a layer tree in two places at once, or something crazy like that, we
> could get the behavior you want (WKView left undisturbed) without
> sacrificing the instantaneous-ness/no-flashyness of WKThumbnailView.
> 
> Maybe it should be about the difference in the WKView's behavior?

That's a good point, but I am having trouble thinking up a good name.

allowsInteractionWithWKView?
canCoexistWithWKView?

[Conrad Shultz]

Committed r191366: <http://trac.webkit.org/changeset/191366>