Bug 150088 – [GTK] Fix build for ENABLE_NETSCAPE_PLUGIN_API=OFF

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Sergio Villar Senin]

[GTK] Fix build for ENABLE_NETSCAPE_PLUGIN_API=OFF

[Sergio Villar Senin]

Created attachment 262985 [details]
Patch

[Michael Catanzaro]

This looks fine to me. We support and require ENABLE_NETSCAPE_PLUGIN_API=OFF if ENABLE_X11_TARGET=OFF.

[Darin Adler]

Comment on attachment 262985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262985&action=review

> Source/WebKit2/PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:32
> +#if ENABLE(NETSCAPE_PLUGIN_API)

On EFL build this fails:

../../Source/WebKit2/PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:32:11: error: missing binary operator before token "("

I think you need to include something here that it’s not currently including, probably "config.h".

> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:31
> -#if ENABLE(PLUGIN_PROCESS)
> +#if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API)

Why use a different order here?

[Carlos Garcia Campos]

Comment on attachment 262985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262985&action=review

> Source/WebKit2/PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:34
> +#endif

I don't think this should be handled here anyway. This is the only source code file of WebKitPluginProcess, if plugin process is disabled, we don't want a binary with an empty main(). This should be handled by the build system, to not build the plugin process binary when plugin process is disabled. But this is not checking plugin process flag, but netscape plugins. It's true that we only support netscape plugins, but again I think that detail of disable plugin process if NPAPI plugins are disabled should be handled by the build system, rather than conditional compilation.

[Sergio Villar Senin]

Closing this