Bug 150088 - [GTK] Fix build for ENABLE_NETSCAPE_PLUGIN_API=OFF
Summary: [GTK] Fix build for ENABLE_NETSCAPE_PLUGIN_API=OFF
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-13 05:08 PDT by Sergio Villar Senin
Modified: 2016-09-19 08:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.42 KB, patch)
2015-10-13 05:09 PDT, Sergio Villar Senin 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2015-10-13 05:08:08 PDT 
[GTK] Fix build for ENABLE_NETSCAPE_PLUGIN_API=OFF
Comment 1 Sergio Villar Senin 2015-10-13 05:09:39 PDT 
Created attachment 262985 [details]
Patch
Comment 2 Michael Catanzaro 2015-10-13 10:14:04 PDT 
This looks fine to me. We support and require ENABLE_NETSCAPE_PLUGIN_API=OFF if ENABLE_X11_TARGET=OFF.
Comment 3 Darin Adler 2015-10-18 16:39:54 PDT 
Comment on attachment 262985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262985&action=review

> Source/WebKit2/PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:32
> +#if ENABLE(NETSCAPE_PLUGIN_API)

On EFL build this fails:

../../Source/WebKit2/PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:32:11: error: missing binary operator before token "("

I think you need to include something here that it’s not currently including, probably "config.h".

> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:31
> -#if ENABLE(PLUGIN_PROCESS)
> +#if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API)

Why use a different order here?
Comment 4 Carlos Garcia Campos 2015-10-18 22:48:23 PDT 
Comment on attachment 262985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262985&action=review

> Source/WebKit2/PluginProcess/EntryPoint/unix/PluginProcessMain.cpp:34
> +#endif

I don't think this should be handled here anyway. This is the only source code file of WebKitPluginProcess, if plugin process is disabled, we don't want a binary with an empty main(). This should be handled by the build system, to not build the plugin process binary when plugin process is disabled. But this is not checking plugin process flag, but netscape plugins. It's true that we only support netscape plugins, but again I think that detail of disable plugin process if NPAPI plugins are disabled should be handled by the build system, rather than conditional compilation.
Comment 5 Sergio Villar Senin 2016-09-19 08:12:45 PDT 
Closing this