Bug 150069 - Add a Mac debug EWS queue
Summary: Add a Mac debug EWS queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-12 17:47 PDT by Alexey Proskuryakov
Modified: 2015-10-12 19:50 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (3.46 KB, patch)
2015-10-12 17:49 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed patch (3.45 KB, patch)
2015-10-12 18:31 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed patch (3.42 KB, patch)
2015-10-12 18:38 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-10-12 17:47:34 PDT 
Let's add a Mac debug EWS queue. And make it 32-bit to increase the coverage in this direction too.
Comment 1 Alexey Proskuryakov 2015-10-12 17:49:16 PDT 
Created attachment 262947 [details]
proposed patch

I think that this should do it...
Comment 2 Alexey Proskuryakov 2015-10-12 18:31:45 PDT 
Created attachment 262952 [details]
proposed patch

Now that I actually tried to run the tests, I realize that we can't test WK2, because modern WebKit API is 64-bit only.
Comment 3 Alexey Proskuryakov 2015-10-12 18:38:30 PDT 
Created attachment 262954 [details]
proposed patch

But we can't enable tests in WK1 either - they run, but there are lots of slightly different results.
Comment 4 WebKit Commit Bot 2015-10-12 18:41:23 PDT 
Attachment 262954 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/ews.json:43:  Expecting property name enclosed in double quotes: line 43 column 5 (char 877)  [json/syntax] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2015-10-12 19:04:09 PDT 
Comment on attachment 262954 [details]
proposed patch

r=me
Comment 6 WebKit Commit Bot 2015-10-12 19:50:09 PDT 
Comment on attachment 262954 [details]
proposed patch

Clearing flags on attachment: 262954

Committed r190922: <http://trac.webkit.org/changeset/190922>
Comment 7 WebKit Commit Bot 2015-10-12 19:50:13 PDT 
All reviewed patches have been landed.  Closing bug.