Bug 150068 - REGRESSION(r53318): background-repeat: space with gradients doesn't render correctly
Summary: REGRESSION(r53318): background-repeat: space with gradients doesn't render co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2015-10-12 17:43 PDT by Simon Fraser (smfr)
Modified: 2015-10-14 10:29 PDT (History)
5 users (show)

See Also:

Attachments
Testcase (1.22 KB, text/html)
2015-10-12 17:43 PDT, Simon Fraser (smfr) 		no flags Details
Patch (5.56 KB, patch)
2015-10-13 18:40 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (7.29 KB, patch)
2015-10-14 09:05 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-10-12 17:43:37 PDT 
Created attachment 262946 [details]
Testcase

In attached test case, the last two boxes look wrong (and different from Chrome).
Comment 1 Radar WebKit Bug Importer 2015-10-12 17:44:16 PDT 
<rdar://problem/23081477>
Comment 2 Said Abou-Hallawa 2015-10-13 18:40:11 PDT 
Created attachment 263049 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-10-13 18:48:44 PDT 
Comment on attachment 263049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263049&action=review

> Source/WebCore/platform/graphics/GradientImage.cpp:66
> -    m_gradient->adjustParametersForTiledDrawing(adjustedSize, adjustedSrcRect);
> +
> +    if (spacing.isZero())
> +        m_gradient->adjustParametersForTiledDrawing(adjustedSize, adjustedSrcRect);

I think it would be better to pass 'spacing' into Gradient::adjustParametersForTiledDrawing() and do the check there, since it makes the other decisions about adjustment.
Comment 4 Said Abou-Hallawa 2015-10-14 09:05:41 PDT 
Created attachment 263079 [details]
Patch
Comment 5 WebKit Commit Bot 2015-10-14 10:29:54 PDT 
Comment on attachment 263079 [details]
Patch

Clearing flags on attachment: 263079

Committed r191048: <http://trac.webkit.org/changeset/191048>
Comment 6 WebKit Commit Bot 2015-10-14 10:29:57 PDT 
All reviewed patches have been landed.  Closing bug.