RESOLVED FIXED 150066
Add basic canvas tests 
https://bugs.webkit.org/show_bug.cgi?id=150066
Summary Add basic canvas tests
Jon Lee
Reported 2015-10-12 17:22:20 PDT
Add basic canvas tests
Attachments
Patch (14.81 KB, patch)
2015-10-12 17:38 PDT, Jon Lee 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-10-12 17:22:38 PDT
<rdar://problem/23081143>
Jon Lee
Comment 2 2015-10-12 17:38:53 PDT
Created attachment 262945 [details] Patch
Said Abou-Hallawa
Comment 3 2015-10-12 17:48:46 PDT
Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review > PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5 > + var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2)); You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2).
Jon Lee
Comment 4 2015-10-12 17:51:56 PDT
Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review >> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5 >> + var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2)); > > You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2). maxSize is an int though...
Said Abou-Hallawa
Comment 5 2015-10-12 17:57:01 PDT
Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review >>> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5 >>> + var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2)); >> >> You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2). > > maxSize is an int though... Never mind. I thought maxSize is a rectangle of max width and max height and not a side in a square side.
Dean Jackson
Comment 6 2015-10-12 18:05:31 PDT
Comment on attachment 262945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review > PerformanceTests/Animometer/tests/simple/resources/simple-canvas.js:51 > +} > + > + > +function SimpleCanvasBenchmark(suite, test, options, recordTable, progressBar) { Nit: extra blank line
Jon Lee
Comment 7 2015-10-12 18:12:56 PDT
Committed r190912: <http://trac.webkit.org/changeset/190912>
Note You need to log in before you can comment on or make changes to this bug.