Bug 150066 - Add basic canvas tests
Summary: Add basic canvas tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 149053
  Show dependency tree / graph
 
Reported: 2015-10-12 17:22 PDT by Jon Lee
Modified: 2015-10-12 18:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.81 KB, patch)
2015-10-12 17:38 PDT, Jon Lee 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2015-10-12 17:22:20 PDT 
Add basic canvas tests
Comment 1 Radar WebKit Bug Importer 2015-10-12 17:22:38 PDT 
<rdar://problem/23081143>
Comment 2 Jon Lee 2015-10-12 17:38:53 PDT 
Created attachment 262945 [details]
Patch
Comment 3 Said Abou-Hallawa 2015-10-12 17:48:46 PDT 
Comment on attachment 262945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review

> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5
> +    var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));

You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2).
Comment 4 Jon Lee 2015-10-12 17:51:56 PDT 
Comment on attachment 262945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review

>> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5
>> +    var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));
> 
> You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2).

maxSize is an int though...
Comment 5 Said Abou-Hallawa 2015-10-12 17:57:01 PDT 
Comment on attachment 262945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review

>>> PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js:5
>>> +    var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));
>> 
>> You can use maxSize.center() instead of new Point(maxSize/2, maxSize/2).
> 
> maxSize is an int though...

Never mind. I thought maxSize is a rectangle of max width and max height and not a side in a square side.
Comment 6 Dean Jackson 2015-10-12 18:05:31 PDT 
Comment on attachment 262945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262945&action=review

> PerformanceTests/Animometer/tests/simple/resources/simple-canvas.js:51
> +}
> +
> +
> +function SimpleCanvasBenchmark(suite, test, options, recordTable, progressBar) {

Nit: extra blank line
Comment 7 Jon Lee 2015-10-12 18:12:56 PDT 
Committed r190912: <http://trac.webkit.org/changeset/190912>