Bug 150060 - Refactor tune() to pass in an integer-based count
Summary: Refactor tune() to pass in an integer-based count
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 149053
  Show dependency tree / graph
 
Reported: 2015-10-12 15:55 PDT by Jon Lee
Modified: 2015-10-12 17:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2015-10-12 16:00 PDT, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2015-10-12 17:04 PDT, Jon Lee 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2015-10-12 15:55:22 PDT 
Tuning the # of objects to paint will always be integral.. All of the stages floor the delta count, so factor that logic out, and expect an integer count.
Comment 1 Radar WebKit Bug Importer 2015-10-12 15:55:59 PDT 
<rdar://problem/23079435>
Comment 2 Jon Lee 2015-10-12 16:00:31 PDT 
Created attachment 262935 [details]
Patch
Comment 3 Jon Lee 2015-10-12 17:04:36 PDT 
Created attachment 262941 [details]
Patch
Comment 4 Said Abou-Hallawa 2015-10-12 17:09:13 PDT 
Comment on attachment 262941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262941&action=review

> PerformanceTests/ChangeLog:24
> +        (LayeringTextStage.prototype.tune): Ditto.

Nice. informal r=me.
Comment 5 Jon Lee 2015-10-12 17:11:51 PDT 
Committed r190908: <http://trac.webkit.org/changeset/190908>