Bug 150053 - Refactor test suites to a separate class
Summary: Refactor test suites to a separate class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 149053
  Show dependency treegraph
 
Reported: 2015-10-12 15:17 PDT by Jon Lee
Modified: 2015-10-12 16:23 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.47 KB, patch)
2015-10-12 15:20 PDT, Jon Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2015-10-12 15:17:07 PDT
Refactor test suites to a separate class
Comment 1 Radar WebKit Bug Importer 2015-10-12 15:17:39 PDT
<rdar://problem/23078645>
Comment 2 Jon Lee 2015-10-12 15:20:11 PDT
Created attachment 262927 [details]
Patch
Comment 3 Dean Jackson 2015-10-12 15:33:08 PDT
Comment on attachment 262927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262927&action=review

> PerformanceTests/Animometer/runner/resources/animometer.js:120
> +        var suiteDiv = document.createDocumentFragment();

Is there a reason you didn't create a "div"?
Comment 4 Said Abou-Hallawa 2015-10-12 15:51:53 PDT
Comment on attachment 262927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262927&action=review

> PerformanceTests/Animometer/runner/resources/animometer.js:67
> +            enabledSuites.push(checkbox.suite);

Is there a reason why we can not use enabledSuites.push(Suites[i])?

> PerformanceTests/Animometer/runner/resources/animometer.js:125
> +        checkbox.suite = suite;

I am not sure about the cost of this assignment. Do we make a copy of the suite structure and assign it in the suite member of the checkbox variable?

> PerformanceTests/ChangeLog:30
> +

informal r=me
Comment 5 Jon Lee 2015-10-12 16:22:56 PDT
Committed r190902: <http://trac.webkit.org/changeset/190902>