Bug 150051 - [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
Summary: [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-12 15:05 PDT by Myles C. Maxfield
Modified: 2015-12-04 15:22 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2015-10-12 15:06 PDT, Myles C. Maxfield
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-10-12 15:05:17 PDT
[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
Comment 1 Myles C. Maxfield 2015-10-12 15:06:23 PDT
Created attachment 262925 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-10-12 15:24:10 PDT
Comment on attachment 262925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:610
> +#if !PLATFORM(COCOA)
> +    if (run.length() > 1 && typesettingFeatures())
>          return Complex;
> +#endif

We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef?
Comment 3 Myles C. Maxfield 2015-10-12 15:39:54 PDT
Comment on attachment 262925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review

>> Source/WebCore/platform/graphics/FontCascade.cpp:610
>> +#endif
> 
> We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef?

I think in this case, it would be worse. This thing is so simple that adding another function with two implementations is worse than this tiny ifdef.
Comment 4 Myles C. Maxfield 2015-10-12 15:41:12 PDT
Committed r190895: <http://trac.webkit.org/changeset/190895>
Comment 5 Radar WebKit Bug Importer 2015-12-04 15:22:29 PST
<rdar://problem/23768511>