RESOLVED FIXED Bug 150051
[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures() 
https://bugs.webkit.org/show_bug.cgi?id=150051
Summary [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
Myles C. Maxfield
Reported 2015-10-12 15:05:17 PDT
[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
Attachments
Patch (2.64 KB, patch)
2015-10-12 15:06 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-10-12 15:06:23 PDT
Created attachment 262925 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-10-12 15:24:10 PDT
Comment on attachment 262925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:610 > +#if !PLATFORM(COCOA) > + if (run.length() > 1 && typesettingFeatures()) > return Complex; > +#endif We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef?
Myles C. Maxfield
Comment 3 2015-10-12 15:39:54 PDT
Comment on attachment 262925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review >> Source/WebCore/platform/graphics/FontCascade.cpp:610 >> +#endif > > We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef? I think in this case, it would be worse. This thing is so simple that adding another function with two implementations is worse than this tiny ifdef.
Myles C. Maxfield
Comment 4 2015-10-12 15:41:12 PDT
Committed r190895: <http://trac.webkit.org/changeset/190895>
Radar WebKit Bug Importer
Comment 5 2015-12-04 15:22:29 PST
<rdar://problem/23768511>
Note You need to log in before you can comment on or make changes to this bug.