Bug 150045 - Simplify WeakBlock visit and reap phases
Summary: Simplify WeakBlock visit and reap phases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-12 13:36 PDT by Joseph Pecoraro
Modified: 2015-10-13 17:10 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.12 KB, patch)
2015-10-12 13:39 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-12 13:36:52 PDT 
Simplify WeakBlock visit and reap phases.

In marking, WeakBlocks are visited last after MarkedBlocks have been visited. Likewise reaping happens after marking. In both cases, all MarkedBlocks should be either Marked or Retired. We shouldn't encounter any that are Allocated.
Comment 1 Joseph Pecoraro 2015-10-12 13:39:27 PDT 
Created attachment 262916 [details]
[PATCH] Proposed Fix

I've been running with this change without any problems.
Comment 2 Geoffrey Garen 2015-10-12 13:55:22 PDT 
Comment on attachment 262916 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2015-10-13 17:10:44 PDT 
Comment on attachment 262916 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 262916

Committed r191015: <http://trac.webkit.org/changeset/191015>
Comment 4 WebKit Commit Bot 2015-10-13 17:10:48 PDT 
All reviewed patches have been landed.  Closing bug.