Bug 150037 - PDFPlugin should take advantage of threaded scrolling
Summary: PDFPlugin should take advantage of threaded scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-12 11:12 PDT by Tim Horton
Modified: 2015-11-02 16:47 PST (History)
6 users (show)

See Also:

Attachments
Patch (239.50 KB, patch)
2015-10-12 11:14 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (223.03 KB, patch)
2015-10-19 19:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (221.42 KB, patch)
2015-11-02 14:29 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (221.66 KB, patch)
2015-11-02 15:21 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-10-12 11:12:50 PDT 
PDFPlugin should take advantage of threaded scrolling
Comment 1 Tim Horton 2015-10-12 11:14:37 PDT 
Created attachment 262905 [details]
Patch
Comment 2 Tim Horton 2015-10-19 19:34:47 PDT 
Created attachment 263543 [details]
Patch
Comment 3 Tim Horton 2015-11-02 14:29:25 PST 
Created attachment 264628 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-02 14:32:25 PST 
Attachment 264628 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1905:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1724:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:239:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2015-11-02 15:21:28 PST 
Created attachment 264635 [details]
Patch
Comment 6 WebKit Commit Bot 2015-11-02 15:24:44 PST 
Attachment 264635 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1905:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1724:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:240:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 36 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2015-11-02 16:19:08 PST 
Comment on attachment 264635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264635&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:536
> +    m_accessibilityObject.get().pdfLayerController = m_pdfLayerController.get();
> +    m_accessibilityObject.get().parent = webFrame()->page()->accessibilityRemoteObject();

.get(). :|

> Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1423
> +        }

Weird that there's a fall-through here. I'd add a break; just to be sure. Same for all outer cases.

> Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:1749
> +    PDFSelection *selectionForInitialSearch = [initialSelection copy];

Please use a RetainPtr here.

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:374
> +    std::function<void(bool)> _completionHandler;

void (bool).

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:882
> +//    context.translate(0, -m_size.height());

What.
Comment 8 Tim Horton 2015-11-02 16:27:50 PST 
http://trac.webkit.org/changeset/191922