WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
150035
[Curl] Increase limit of parallel network requests.
https://bugs.webkit.org/show_bug.cgi?id=150035
Summary
[Curl] Increase limit of parallel network requests.
peavo
Reported
2015-10-12 11:03:13 PDT
If the limit is low, other network requests will often be blocked until active requests finishes. This can affect performance in a negative way.
Attachments
Patch
(1.30 KB, patch)
2015-10-12 11:09 PDT
,
peavo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
peavo
Comment 1
2015-10-12 11:09:53 PDT
Created
attachment 262902
[details]
Patch
Alex Christensen
Comment 2
2015-10-12 11:30:22 PDT
Comment on
attachment 262902
[details]
Patch What if the limit is too big? Why is there a limit?
peavo
Comment 3
2015-10-12 11:38:12 PDT
(In reply to
comment #2
)
> Comment on
attachment 262902
[details]
> Patch > > What if the limit is too big? Why is there a limit?
Good point. It might be better to leave this decision to Curl, since it is probably handled well there. In that case, I dont't think a big limit would hurt :)
peavo
Comment 4
2015-10-12 11:56:39 PDT
It seems there already is a Curl option for this (with default 0, meaning infinite number of connections):
http://curl.haxx.se/libcurl/c/CURLMOPT_MAX_TOTAL_CONNECTIONS.html
Since Curl doesn't have a limit here, maybe we shouldn't either? If we limit the number of connections, I think the limit should be higher that it is now at least. Another problem with the limit is that it can effectively block all future network requests if the current connections are never closed (for some reason).
peavo
Comment 5
2015-10-12 13:42:24 PDT
Thanks for reviewing :)
WebKit Commit Bot
Comment 6
2015-10-12 14:22:36 PDT
Comment on
attachment 262902
[details]
Patch Clearing flags on attachment: 262902 Committed
r190887
: <
http://trac.webkit.org/changeset/190887
>
WebKit Commit Bot
Comment 7
2015-10-12 14:22:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug