Bug 150035 - [Curl] Increase limit of parallel network requests.
Summary: [Curl] Increase limit of parallel network requests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-12 11:03 PDT by peavo
Modified: 2015-10-12 14:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.30 KB, patch)
2015-10-12 11:09 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-10-12 11:03:13 PDT
If the limit is low, other network requests will often be blocked until active requests finishes. This can affect performance in a negative way.
Comment 1 peavo 2015-10-12 11:09:53 PDT
Created attachment 262902 [details]
Patch
Comment 2 Alex Christensen 2015-10-12 11:30:22 PDT
Comment on attachment 262902 [details]
Patch

What if the limit is too big?  Why is there a limit?
Comment 3 peavo 2015-10-12 11:38:12 PDT
(In reply to comment #2)
> Comment on attachment 262902 [details]
> Patch
> 
> What if the limit is too big?  Why is there a limit?

Good point. It might be better to leave this decision to Curl, since it is probably handled well there. In that case, I dont't think a big limit would hurt :)
Comment 4 peavo 2015-10-12 11:56:39 PDT
It seems there already is a Curl option for this (with default 0, meaning infinite number of connections):

http://curl.haxx.se/libcurl/c/CURLMOPT_MAX_TOTAL_CONNECTIONS.html

Since Curl doesn't have a limit here, maybe we shouldn't either? If we limit the number of connections, I think the limit should be higher that it is now at least.

Another problem with the limit is that it can effectively block all future network requests if the current connections are never closed (for some reason).
Comment 5 peavo 2015-10-12 13:42:24 PDT
Thanks for reviewing :)
Comment 6 WebKit Commit Bot 2015-10-12 14:22:36 PDT
Comment on attachment 262902 [details]
Patch

Clearing flags on attachment: 262902

Committed r190887: <http://trac.webkit.org/changeset/190887>
Comment 7 WebKit Commit Bot 2015-10-12 14:22:39 PDT
All reviewed patches have been landed.  Closing bug.