RESOLVED FIXED 150032
[GTK][Mac] ICU-related build fixes 
https://bugs.webkit.org/show_bug.cgi?id=150032
Summary [GTK][Mac] ICU-related build fixes
Philippe Normand
Reported 2015-10-12 09:56:03 PDT
I had some link errors and not-found-headers issues related with ICU on Mac.
Attachments
Patch (3.96 KB, patch)
2015-10-12 10:01 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (1.58 KB, patch)
2015-10-21 08:22 PDT, Philippe Normand 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-10-12 10:01:58 PDT
Created attachment 262894 [details] Patch
Carlos Garcia Campos
Comment 2 2015-10-13 00:58:06 PDT
Comment on attachment 262894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review > Source/JavaScriptCore/PlatformGTK.cmake:51 > +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") Why is this specific to darwin? > Source/WTF/wtf/PlatformGTK.cmake:26 > +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") Ditto.
Philippe Normand
Comment 3 2015-10-13 01:03:17 PDT
Comment on attachment 262894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review >> Source/JavaScriptCore/PlatformGTK.cmake:51 >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > > Why is this specific to darwin? No idea. The wonders of CMake on Linux I suppose :)
Carlos Garcia Campos
Comment 4 2015-10-13 01:28:23 PDT
(In reply to comment #3) > Comment on attachment 262894 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262894&action=review > > >> Source/JavaScriptCore/PlatformGTK.cmake:51 > >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > > > > Why is this specific to darwin? > > No idea. The wonders of CMake on Linux I suppose :) If that works for the other platforms, we could avoid conditionals that we don't even understand
Philippe Normand
Comment 5 2015-10-21 08:22:49 PDT
Created attachment 263679 [details] patch
Darin Adler
Comment 6 2015-10-21 08:50:45 PDT
I’m just rubber stamping this; seems fine to me even though I’m not expert on how CMake works.
Philippe Normand
Comment 7 2015-10-22 00:08:45 PDT
Committed r191442: <http://trac.webkit.org/changeset/191442>
Note You need to log in before you can comment on or make changes to this bug.