Bug 150032 - [GTK][Mac] ICU-related build fixes
Summary: [GTK][Mac] ICU-related build fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks: 126492
  Show dependency tree / graph
 
Reported: 2015-10-12 09:56 PDT by Philippe Normand
Modified: 2015-10-22 00:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.96 KB, patch)
2015-10-12 10:01 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
patch (1.58 KB, patch)
2015-10-21 08:22 PDT, Philippe Normand 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-10-12 09:56:03 PDT 
I had some link errors and not-found-headers issues related with ICU on Mac.
Comment 1 Philippe Normand 2015-10-12 10:01:58 PDT 
Created attachment 262894 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-10-13 00:58:06 PDT 
Comment on attachment 262894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review

> Source/JavaScriptCore/PlatformGTK.cmake:51
> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")

Why is this specific to darwin?

> Source/WTF/wtf/PlatformGTK.cmake:26
> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")

Ditto.
Comment 3 Philippe Normand 2015-10-13 01:03:17 PDT 
Comment on attachment 262894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review

>> Source/JavaScriptCore/PlatformGTK.cmake:51
>> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
> 
> Why is this specific to darwin?

No idea. The wonders of CMake on Linux I suppose :)
Comment 4 Carlos Garcia Campos 2015-10-13 01:28:23 PDT 
(In reply to comment #3)
> Comment on attachment 262894 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262894&action=review
> 
> >> Source/JavaScriptCore/PlatformGTK.cmake:51
> >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
> > 
> > Why is this specific to darwin?
> 
> No idea. The wonders of CMake on Linux I suppose :)

If that works for the other platforms, we could avoid conditionals that we don't even understand
Comment 5 Philippe Normand 2015-10-21 08:22:49 PDT 
Created attachment 263679 [details]
patch
Comment 6 Darin Adler 2015-10-21 08:50:45 PDT 
I’m just rubber stamping this; seems fine to me even though I’m not expert on how CMake works.
Comment 7 Philippe Normand 2015-10-22 00:08:45 PDT 
Committed r191442: <http://trac.webkit.org/changeset/191442>