Bug 150024 - REGRESSION(r189567): Inputs with "display:flex" don't shrink as they used to in Safari 9.0
Summary: REGRESSION(r189567): Inputs with "display:flex" don't shrink as they used to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-12 00:17 PDT by Nikita Vasilyev
Modified: 2016-05-20 09:07 PDT (History)
4 users (show)

See Also:

Attachments
[Image] Actual/Expected (18.84 KB, image/png)
2015-10-12 00:17 PDT, Nikita Vasilyev 		no flags Details
[HTML] Reduction (1.36 KB, text/html)
2015-10-12 00:18 PDT, Nikita Vasilyev 		no flags Details
Reduced test case (396 bytes, text/html)
2016-05-19 02:16 PDT, Sergio Villar Senin 		no flags Details
Web Engines Rendering (5.31 KB, image/png)
2016-05-19 02:25 PDT, Sergio Villar Senin 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-10-12 00:17:05 PDT 
Created attachment 262879 [details]
[Image] Actual/Expected

See the attached image and HTML reduction.
Comment 1 Nikita Vasilyev 2015-10-12 00:18:04 PDT 
Created attachment 262880 [details]
[HTML] Reduction
Comment 2 Nikita Vasilyev 2015-10-12 23:25:19 PDT 
This regressed in http://trac.webkit.org/changeset/189567, so the current behaviour is probably the intended one. I wonder how many websites this change will break.
Comment 3 Sergio Villar Senin 2015-10-16 05:19:00 PDT 
(In reply to comment #2)
> This regressed in http://trac.webkit.org/changeset/189567, so the current
> behaviour is probably the intended one. I wonder how many websites this
> change will break.

Firefox renders that test as WebKit ToT
Comment 4 Sergio Villar Senin 2015-10-16 05:20:43 PDT 
Also what happens if you set min-width:0px; as suggested in the ChangeLog?
Comment 5 Jon Lee 2016-05-16 14:03:17 PDT 
Chrome shows the same results as we do. Adding min-width:0 fixes the issue.
Comment 6 Sergio Villar Senin 2016-05-19 02:14:32 PDT 
(In reply to comment #5)
> Chrome shows the same results as we do. Adding min-width:0 fixes the issue.

I think that the rendering in ToT is correct. I've checked Firefox and the input item is sized the same (looks like firefox has a bug as it draws a too wide outline for the filter-bar but the search item is sized as in WebKit).
Comment 7 Sergio Villar Senin 2016-05-19 02:16:25 PDT 
Created attachment 279374 [details]
Reduced test case

I've removed the non essential stuff.
Comment 8 Sergio Villar Senin 2016-05-19 02:25:27 PDT 
Created attachment 279375 [details]
Web Engines Rendering

These are the renderings of FF, Chrome and WebKit. All of them ToT. As you can see the only difference is the outline of the parent flex element. The search input item is not shrank at all in any of the engines.

That's why I don't think that's a regression. If you want to achieve Safari 9 results then you definitely need to use min-width:0px as suggested.
Comment 9 Dave Hyatt 2016-05-20 09:07:44 PDT 
Agreed. This is not a bug.