Some checks for the target iOS version are unnecessary.
Created attachment 262829 [details] Remove redundant version checks
Attachment 262829 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 262829 [details] Remove redundant version checks View in context: https://bugs.webkit.org/attachment.cgi?id=262829&action=review > Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:58 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 1090) I suggest removing these parentheses. > Source/WebCore/svg/SVGToOTFFontConversion.cpp:1109 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000) Ditto. > Source/WebCore/svg/SVGToOTFFontConversion.cpp:1407 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000) Ditto. > Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm:105 > +#if defined UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP && UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP I didn't know one could use "defined" without parentheses. I suggest adding them for consistency. > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:318 > - 1A8B66B01BC43C860082DF77 /* PageLoadStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8B66AE1BC43C860082DF77 /* PageLoadStateObserver.h */; settings = {ASSET_TAGS = (); }; }; > - 1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; settings = {ASSET_TAGS = (); }; }; > + 1A8B66B01BC43C860082DF77 /* PageLoadStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8B66AE1BC43C860082DF77 /* PageLoadStateObserver.h */; }; > + 1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; }; Is this change intentionally part of this patch? > Tools/WebKitTestRunner/ios/UIKitSPI.h:-48 > -- (void)_handleHIDEvent:(IOHIDEventRef)event; Just to confirm, this was removed because it's unneeded, correct?
Comment on attachment 262829 [details] Remove redundant version checks View in context: https://bugs.webkit.org/attachment.cgi?id=262829&action=review >> Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm:105 >> +#if defined UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP && UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP > > I didn't know one could use "defined" without parentheses. I suggest adding them for consistency. We use both styles throughout the project. >> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:318 >> + 1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; }; > > Is this change intentionally part of this patch? No. Some versions of Xcode added empty ASSET_TAGS arrays, other versions take them out, but this is unrelated to what this patch is about. >> Tools/WebKitTestRunner/ios/UIKitSPI.h:-48 >> -- (void)_handleHIDEvent:(IOHIDEventRef)event; > > Just to confirm, this was removed because it's unneeded, correct? It’s unneeded, but I’ll leave it since it’s outside the scope of this patch.
Committed <http://trac.webkit.org/r190841>.