Bug 149995 - Web Inspector: Improve error messages for internal Inspector code
Summary: Web Inspector: Improve error messages for internal Inspector code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-09 21:29 PDT by Nikita Vasilyev
Modified: 2015-10-10 08:51 PDT (History)
8 users (show)

See Also:

Attachments
[Image] Before/After (445.78 KB, image/png)
2015-10-09 21:29 PDT, Nikita Vasilyev 		no flags Details
Patch (2.11 KB, patch)
2015-10-09 21:32 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (2.11 KB, patch)
2015-10-09 21:33 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-10-09 21:29:00 PDT 
Created attachment 262818 [details]
[Image] Before/After

See the screenshot.
Comment 1 Radar WebKit Bug Importer 2015-10-09 21:29:23 PDT 
<rdar://problem/23059365>
Comment 2 Nikita Vasilyev 2015-10-09 21:32:11 PDT 
Created attachment 262819 [details]
Patch
Comment 3 Nikita Vasilyev 2015-10-09 21:33:20 PDT 
Created attachment 262820 [details]
Patch
Comment 4 Nikita Vasilyev 2015-10-09 21:41:09 PDT 
Note that on the screenshot the following stack trace items appear twice:

    dispatch — InspectorBackend.js:89
    dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42

The first one comes from the logged exception (black text) and the second one comes from console.error (red text). We could have used console.warn to not append the second one, but it wouldn't look like error anymore.
Comment 5 WebKit Commit Bot 2015-10-10 08:51:06 PDT 
Comment on attachment 262820 [details]
Patch

Clearing flags on attachment: 262820

Committed r190839: <http://trac.webkit.org/changeset/190839>
Comment 6 WebKit Commit Bot 2015-10-10 08:51:10 PDT 
All reviewed patches have been landed.  Closing bug.