Bug 149961 - No need to keep setting needsVisit flag in SmallStrings
Summary: No need to keep setting needsVisit flag in SmallStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-09 11:45 PDT by Joseph Pecoraro
Modified: 2015-10-09 16:18 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.07 KB, patch)
2015-10-09 11:47 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-09 11:45:35 PDT 
No need to keep setting needsVisit flag in SmallStrings.

The strings are all setup before GC is enabled by the VM, and all in private functions. No need to keep updating the flag if it couldn't have changed.
Comment 1 Joseph Pecoraro 2015-10-09 11:47:26 PDT 
Created attachment 262782 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-09 16:18:33 PDT 
Comment on attachment 262782 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 262782

Committed r190829: <http://trac.webkit.org/changeset/190829>
Comment 3 WebKit Commit Bot 2015-10-09 16:18:36 PDT 
All reviewed patches have been landed.  Closing bug.