Bug 149960 - [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
Summary: [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-09 10:49 PDT by Simon Fraser (smfr)
Modified: 2015-10-13 12:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2015-10-09 10:50 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-10-09 10:49:54 PDT 
[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
Comment 1 Simon Fraser (smfr) 2015-10-09 10:50:22 PDT 
Created attachment 262780 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-09 14:35:29 PDT 
Comment on attachment 262780 [details]
Patch

Clearing flags on attachment: 262780

Committed r190819: <http://trac.webkit.org/changeset/190819>
Comment 3 WebKit Commit Bot 2015-10-09 14:35:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2015-10-13 12:10:14 PDT 
Comment on attachment 262780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262780&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:81
> +    self.willBeginZoomingCallback = nil;
> +    self.didEndZoomingCallback = nil;
> +    self.didShowKeyboardCallback = nil;
> +    self.didHideKeyboardCallback = nil;
> +
> +    self.zoomToScaleCompletionHandler = nil;
> +    self.showKeyboardCompletionHandler = nil;

I think the best practice is to call release, not call the setter method.