Bug 149955 - Fix the !ENABLE(STREAM_API) build after r190794
Summary: Fix the !ENABLE(STREAM_API) build after r190794
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 149751
  Show dependency tree / graph
 
Reported: 2015-10-09 08:27 PDT by Csaba Osztrogonác
Modified: 2015-10-09 10:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2015-10-09 08:28 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-10-09 08:27:26 PDT 
http://trac.webkit.org/changeset/190794 broke the !ENABLE(STREAM_API) build:

In file included from ../../Source/WebCore/bindings/js/JSDOMWindowBase.h:25:0,
                 from DerivedSources/WebCore/JSDOMWindow.h:25,
                 from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:31:
../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:39:34: error: unused parameter ‘visitor’ [-Werror=unused-parameter]
     void visit(JSC::SlotVisitor& visitor) {
                                  ^
../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:44:36: error: unused parameter ‘globalObject’ [-Werror=unused-parameter]
     void init(JSC::JSGlobalObject& globalObject) {
                                    ^
cc1plus: all warnings being treated as errors
Comment 1 Csaba Osztrogonác 2015-10-09 08:28:43 PDT 
Created attachment 262774 [details]
Patch
Comment 2 youenn fablet 2015-10-09 08:32:15 PDT 
Thanks for fixing it.
LGTM.
Comment 3 WebKit Commit Bot 2015-10-09 10:08:58 PDT 
Comment on attachment 262774 [details]
Patch

Clearing flags on attachment: 262774

Committed r190804: <http://trac.webkit.org/changeset/190804>
Comment 4 WebKit Commit Bot 2015-10-09 10:09:05 PDT 
All reviewed patches have been landed.  Closing bug.