RESOLVED FIXED 149943
Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK 
https://bugs.webkit.org/show_bug.cgi?id=149943
Summary Teach build-webkit to install LLVM binaries for iOS when building for device ...
Daniel Bates
Reported 2015-10-08 20:42:03 PDT
Following the patch for bug #149913 we can teach build-webkit to install the iOS LLVM binaries/headers that are included in WebKitLibraries when building for device with the public iOS SDK.
Attachments
Patch (2.20 KB, patch)
2015-10-08 20:45 PDT, Daniel Bates 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-10-08 20:45:05 PDT
Created attachment 262739 [details] Patch
mitz
Comment 2 2015-10-08 20:50:42 PDT
Comment on attachment 262739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262739&action=review > Tools/Scripts/build-webkit:198 > + if (my $hasInternalSDK = (xcodeSDK() || "") eq "iphoneos.internal") { I don’t think you need to check for undefined xcodeSDK() here
Daniel Bates
Comment 3 2015-10-08 20:51:45 PDT
(In reply to comment #2) > Comment on attachment 262739 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262739&action=review > > > Tools/Scripts/build-webkit:198 > > + if (my $hasInternalSDK = (xcodeSDK() || "") eq "iphoneos.internal") { > > I don’t think you need to check for undefined xcodeSDK() here You're right! This line should read: if (my $hasInternalSDK = xcodeSDK() eq "iphoneos.internal") { Will change before landing.
Daniel Bates
Comment 4 2015-10-08 21:02:29 PDT
Committed r190775: <http://trac.webkit.org/changeset/190775>
Note You need to log in before you can comment on or make changes to this bug.