Bug 149943 - Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
Summary: Teach build-webkit to install LLVM binaries for iOS when building for device ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 9.0
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 149913
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-08 20:42 PDT by Daniel Bates
Modified: 2015-10-08 21:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.20 KB, patch)
2015-10-08 20:45 PDT, Daniel Bates
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-10-08 20:42:03 PDT
Following the patch for bug #149913 we can teach build-webkit to install the iOS LLVM binaries/headers that are included in WebKitLibraries when building for device with the public iOS SDK.
Comment 1 Daniel Bates 2015-10-08 20:45:05 PDT
Created attachment 262739 [details]
Patch
Comment 2 mitz 2015-10-08 20:50:42 PDT
Comment on attachment 262739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262739&action=review

> Tools/Scripts/build-webkit:198
> +        if (my $hasInternalSDK = (xcodeSDK() || "") eq "iphoneos.internal") {

I don’t think you need to check for undefined xcodeSDK() here
Comment 3 Daniel Bates 2015-10-08 20:51:45 PDT
(In reply to comment #2)
> Comment on attachment 262739 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262739&action=review
> 
> > Tools/Scripts/build-webkit:198
> > +        if (my $hasInternalSDK = (xcodeSDK() || "") eq "iphoneos.internal") {
> 
> I don’t think you need to check for undefined xcodeSDK() here

You're right! This line should read:

if (my $hasInternalSDK = xcodeSDK() eq "iphoneos.internal") {

Will change before landing.
Comment 4 Daniel Bates 2015-10-08 21:02:29 PDT
Committed r190775: <http://trac.webkit.org/changeset/190775>