Bug 149942 - Perf dashboard erroneously shows an old OS build in A/B testing range
Summary: Perf dashboard erroneously shows an old OS build in A/B testing range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-08 20:12 PDT by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
9 users (show)

See Also:

Attachments
Fixes the bug (8.92 KB, patch)
2015-10-08 20:27 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Removed a stale comment (8.83 KB, patch)
2015-10-08 20:28 PDT, Ryosuke Niwa 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-08 20:12:46 PDT 
Ordering OS builds lexicologically turned out be a bad idea
since 15A25 falls between 15A242 and 15A251.

Use a fake/synthetic timestamp to force the commonly understood total order.
Comment 1 Ryosuke Niwa 2015-10-08 20:27:37 PDT 
Created attachment 262736 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2015-10-08 20:28:41 PDT 
Created attachment 262737 [details]
Removed a stale comment
Comment 3 Ryosuke Niwa 2015-10-08 20:29:16 PDT 
Comment on attachment 262737 [details]
Removed a stale comment

View in context: https://bugs.webkit.org/attachment.cgi?id=262737&action=review

> Websites/perf.webkit.org/tools/pull-os-versions.py:24
> +    parser.add_argument('--seconds-to-sleep', type=float, default=43200, help='The seconds to sleep between iterations')

We only update OS builds every 12 hours.
Comment 4 Ryosuke Niwa 2015-10-09 14:00:57 PDT 
Committed r190817: <http://trac.webkit.org/changeset/190817>