Bug 149939 - WKWebView needs SPI to customize immediate actions
Summary: WKWebView needs SPI to customize immediate actions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-08 16:29 PDT by Beth Dakin
Modified: 2015-10-09 16:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (134.31 KB, patch)
2015-10-08 22:05 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (143.21 KB, patch)
2015-10-08 22:53 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (143.04 KB, patch)
2015-10-09 10:50 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (143.09 KB, patch)
2015-10-09 14:56 PDT, Beth Dakin
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-10-08 16:29:17 PDT
WKWebView needs SPI to customize immediate actions

rdar://problem/20016849
Comment 1 Beth Dakin 2015-10-08 22:05:35 PDT
Created attachment 262746 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-08 22:09:04 PDT
Attachment 262746 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/PageClientImpl.mm:825:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebKit2/Shared/WebHitTestResultData.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/Shared/API/APIHitTestResult.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:73:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:58:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1156:  The parameter name "hitTestResultData" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1158:  The parameter name "hitTestResultData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 10 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2015-10-08 22:53:34 PDT
Created attachment 262750 [details]
Patch

Trying to fix these red bots.
Comment 4 WebKit Commit Bot 2015-10-08 22:55:33 PDT
Attachment 262750 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Beth Dakin 2015-10-09 10:50:09 PDT
Created attachment 262779 [details]
Patch
Comment 6 WebKit Commit Bot 2015-10-09 10:53:31 PDT
Attachment 262779 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Beth Dakin 2015-10-09 14:56:18 PDT
Created attachment 262796 [details]
Patch
Comment 8 WebKit Commit Bot 2015-10-09 14:59:42 PDT
Attachment 262796 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebHitTestResultData.mm:81:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Beth Dakin 2015-10-09 15:25:39 PDT
Thank you!!!! http://trac.webkit.org/changeset/190823