Bug 149920 - [GTK] Stop using a nested main loop for popup menus
Summary: [GTK] Stop using a nested main loop for popup menus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-10-08 02:46 PDT by Carlos Garcia Campos
Modified: 2015-10-08 03:07 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.60 KB, patch)
2015-10-08 02:51 PDT, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-10-08 02:46:39 PDT
WebPageProxy used to expect the popup menus to run in a nested main loop and invalidated the object right after showing it. But this is nor longer the case, so there's no reason to keep using the nested main loop.
Comment 1 Carlos Garcia Campos 2015-10-08 02:51:32 PDT
Created attachment 262683 [details]
Patch
Comment 2 Sergio Villar Senin 2015-10-08 03:03:26 PDT
Comment on attachment 262683 [details]
Patch

let's nuke them all!
Comment 3 Carlos Garcia Campos 2015-10-08 03:07:21 PDT
Committed r190717: <http://trac.webkit.org/changeset/190717>