WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149907
Add a page that cycles through v2 dashboards
https://bugs.webkit.org/show_bug.cgi?id=149907
Summary
Add a page that cycles through v2 dashboards
Ryosuke Niwa
Reported
2015-10-07 17:24:37 PDT
Add a kioski friendly page that cycles through dashboards.
Attachments
Adds cycler.html
(3.16 KB, patch)
2015-10-07 17:31 PDT
,
Ryosuke Niwa
cdumez
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2015-10-07 17:31:16 PDT
Created
attachment 262661
[details]
Adds cycler.html
Chris Dumez
Comment 2
2015-10-07 18:47:20 PDT
Comment on
attachment 262661
[details]
Adds cycler.html View in context:
https://bugs.webkit.org/attachment.cgi?id=262661&action=review
r=me with nits.
> Websites/perf.webkit.org/public/cycler.html:18 > + if (request.readyState != 4)
I personally prefer to use the XMLHttpRequest constants instead of hard-coding values like this as I think it is more readable: if (request.readyState != XMLHttpRequest.DONE)
> Websites/perf.webkit.org/public/cycler.html:38 > +function loadNextURL(i) {
I would have called it loadURLAt(i).
> Websites/perf.webkit.org/public/cycler.html:55 > + setTimeout(loadNextURL.bind(window, i), 30 * 1000);
I think it would be nice to move this 30 to a global variable with a meaningful name so it can easily be tweaked later if needed.
Ryosuke Niwa
Comment 3
2015-10-07 19:07:09 PDT
Committed
r190702
: <
http://trac.webkit.org/changeset/190702
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug