Bug 149894 - Make the site name configurable in perf dashboard
Summary: Make the site name configurable in perf dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-07 13:52 PDT by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
7 users (show)

See Also:

Attachments
Fixes the bug (5.17 KB, patch)
2015-10-07 14:01 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-07 13:52:57 PDT 
Right now, we have to modify HTML files to change the app name.
We should make it configurable through config.json.
Comment 1 Ryosuke Niwa 2015-10-07 14:01:04 PDT 
Created attachment 262640 [details]
Fixes the bug
Comment 2 Chris Dumez 2015-10-07 14:05:15 PDT 
Comment on attachment 262640 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=262640&action=review

r=me with comments.

> Websites/perf.webkit.org/public/index.html:1224
> +        document.querySelector('h1 a').textContent = manifest.siteTitle;

May be nicer / more robust to have an id for the <a> element.

> Websites/perf.webkit.org/public/index.html:1237
> +<h1><a href="/"></a></h1>

I would keep "Perf Monitor" in there (similarly to what you did for the title), just for readability, even though it does not matter in practice.
Comment 3 Ryosuke Niwa 2015-10-07 14:23:43 PDT 
Thanks for the reviews!
Comment 4 Ryosuke Niwa 2015-10-07 14:25:21 PDT 
Committed r190687: <http://trac.webkit.org/changeset/190687>