Bug 149890 - [CSS Grid Layout] Fix grid-{row, column, area} shorthand CSSOM serialization
Summary: [CSS Grid Layout] Fix grid-{row, column, area} shorthand CSSOM serialization
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 149891
  Show dependency treegraph
 
Reported: 2015-10-07 13:16 PDT by Javier Fernandez
Modified: 2020-03-30 12:02 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.57 KB, patch)
2015-10-07 13:37 PDT, Javier Fernandez
svillar: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2015-10-07 13:16:05 PDT
The grid-row, grid-column and grid-area shorthands must use slash instead of whitespace as separator.
Comment 1 Javier Fernandez 2015-10-07 13:29:12 PDT
Fixing this bug would require to merge http://crrev.com/1132753002 patch.
Comment 2 Javier Fernandez 2015-10-07 13:37:54 PDT
Created attachment 262632 [details]
Patch
Comment 3 Sergio Villar Senin 2015-10-08 05:08:57 PDT
Comment on attachment 262632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262632&action=review

> Source/WebCore/css/CSSPropertyNames.in:493
> +-webkit-grid-area [Longhands=-webkit-grid-row-start|-webkit-grid-column-start|-webkit-grid-row-end|-webkit-grid-column-end]

Wow this is bad. This means that we're expanding incorrectly the shorthand and that we have no tests to verify that. Please use a different bug to upload this change with its corresponding test.
Comment 4 Carlos Alberto Lopez Perez 2020-03-30 12:02:44 PDT
I think this is causing failures on the WPT test https://wpt.live/css/css-grid/parsing/grid-area-valid.html