Bug 149851 - WKPage needs to expose a KVO-compliant object, similar to WKWebView
Summary: WKPage needs to expose a KVO-compliant object, similar to WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-06 10:39 PDT by Anders Carlsson
Modified: 2015-10-06 12:12 PDT (History)
0 users

See Also:

Attachments
Patch (22.43 KB, patch)
2015-10-06 10:41 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (23.10 KB, patch)
2015-10-06 11:32 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-10-06 10:39:47 PDT 
WKPage needs to expose a KVO-compliant object, similar to WKWebView
Comment 1 Anders Carlsson 2015-10-06 10:41:51 PDT 
Created attachment 262522 [details]
Patch
Comment 2 mitz 2015-10-06 10:57:49 PDT 
Comment on attachment 262522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262522&action=review

> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:36
> +WK_EXPORT id WKPageCreatePageObserver(WKPageRef page);

Perhaps this should be WKPageCreateObservableState and return an id <_WKObservablePageState>.

This function may also need to be annotated for ARC.
Comment 3 Anders Carlsson 2015-10-06 11:32:00 PDT 
Created attachment 262529 [details]
Patch
Comment 4 Anders Carlsson 2015-10-06 12:12:07 PDT 
Committed r190631: <http://trac.webkit.org/changeset/190631>