Bug 149842 - Enable WritableStream by default
Summary: Enable WritableStream by default
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on: 149751 215267
Blocks: 138561
  Show dependency treegraph
Reported: 2015-10-06 07:27 PDT by youenn fablet
Modified: 2020-08-26 10:36 PDT (History)
5 users (show)

See Also:

Patch (1.24 KB, patch)
2020-08-26 05:34 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-10-06 07:27:30 PDT
We should implement https://streams.spec.whatwg.org/#ws-class
Comment 1 Xabier Rodríguez Calvar 2015-10-06 07:30:46 PDT
I have it ready, I will begin upstreaming step by step soon.
Comment 2 Domenic Denicola 2017-03-28 00:58:11 PDT
I noticed that Safari Tech Preview implements an earlier version of the spec. What are the plans for updating to the latest version? The spec is quite stable these days. We have been tweaking edge case behaviors over the last month (e.g. what happens if you abort() then immediately close()) and have arrived at a place we are pretty happy with.

The tests are also available in web-platform-tests.
Comment 3 youenn fablet 2017-03-28 08:40:35 PDT
Hi Domenic,

It would be good to update to the latest spec but I haven't been able to allocate time for it. Hopefully, I will have some time during the summer.
Let me know if there is any use case where not having writable stream support is highly damageable.

From what I heard from you, I guess all pipe corner cases are now ironed out, that is really good and we should also be able to refresh the ReadableStream implementation.
Comment 4 Domenic Denicola 2017-03-30 23:05:53 PDT
That's great! Yeah, we are also happy with pipeTo().

I just noticed that Safari 10.1 shipped with an older version of the writable stream spec though :-/. Is there any chance of disabling it or similar until it is updated to the latest spec?
Comment 5 youenn fablet 2020-08-26 05:34:54 PDT
Created attachment 407292 [details]
Comment 6 EWS 2020-08-26 10:35:03 PDT
Committed r266172: <https://trac.webkit.org/changeset/266172>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407292 [details].
Comment 7 Radar WebKit Bug Importer 2020-08-26 10:36:20 PDT