Bug 149840 - [CSS Grid Layout] Modify grid item height doesn't work
Summary: [CSS Grid Layout] Modify grid item height doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2015-10-06 06:26 PDT by Javier Fernandez
Modified: 2015-10-07 06:14 PDT (History)
9 users (show)

See Also:

Attachments
test case (510 bytes, text/html)
2015-10-06 06:26 PDT, Javier Fernandez 		no flags Details
Patch (9.77 KB, patch)
2015-10-06 06:44 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (9.73 KB, patch)
2015-10-07 05:05 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (9.73 KB, patch)
2015-10-07 05:19 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2015-10-06 06:26:15 PDT 
Created attachment 262512 [details]
test case

In the attached example if you click the "Test" button, the grid item's height is set to 100px, however the item is not modified at all.

You can test it live at:
http://jsbin.com/vokuru/edit?html,output
Comment 1 Javier Fernandez 2015-10-06 06:44:50 PDT 
Created attachment 262513 [details]
Patch
Comment 2 Sergio Villar Senin 2015-10-07 01:38:19 PDT 
Comment on attachment 262513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262513&action=review

> Source/WebCore/ChangeLog:1
> +2015-10-06  Javier Fernandez  <jfernandez@igalia.com>

Looks like there is a missing empty line here.

> Source/WebCore/ChangeLog:20
> +        No new tests, but added some additional cases.

I'd remove this, additional test cases are new tests.
Comment 3 Javier Fernandez 2015-10-07 05:05:03 PDT 
Created attachment 262595 [details]
Patch
Comment 4 Sergio Villar Senin 2015-10-07 05:12:52 PDT 
BTW the bug title has a typo: Gird -> Grid, correct it and the ChangeLogs
Comment 5 Javier Fernandez 2015-10-07 05:19:59 PDT 
Created attachment 262596 [details]
Patch
Comment 6 WebKit Commit Bot 2015-10-07 06:14:43 PDT 
Comment on attachment 262596 [details]
Patch

Clearing flags on attachment: 262596

Committed r190665: <http://trac.webkit.org/changeset/190665>
Comment 7 WebKit Commit Bot 2015-10-07 06:14:48 PDT 
All reviewed patches have been landed.  Closing bug.