There are currently a few compile errors when compiling WinCairo with GStreamer: InbandTextTrackPrivateGStreamer.cpp(86): error C2668: 'WTF::GThreadSafeMainLoopSource::schedule': ambiguous call to overloaded function
Created attachment 262511 [details] Patch
Comment on attachment 262511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262511&action=review > Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:89 > - [protector] { protector->notifyTrackOfSample(); }); > + static_cast<std::function<void()>>( > + [protector] { > + protector->notifyTrackOfSample(); > + })); Just std::function<void ()>([protector] { ... }) should work, with no casts.
Created attachment 262523 [details] Patch
(In reply to comment #2) > Comment on attachment 262511 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262511&action=review > > > Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:89 > > - [protector] { protector->notifyTrackOfSample(); }); > > + static_cast<std::function<void()>>( > > + [protector] { > > + protector->notifyTrackOfSample(); > > + })); > > Just > > std::function<void ()>([protector] { ... }) > > should work, with no casts. Thanks, that's much better than my casts :)
Thanks for reviewing, Alex!
Comment on attachment 262523 [details] Patch Clearing flags on attachment: 262523 Committed r190643: <http://trac.webkit.org/changeset/190643>
All reviewed patches have been landed. Closing bug.