Bug 149839 - [WinCairo] GStreamer compile errors.
Summary: [WinCairo] GStreamer compile errors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-06 05:09 PDT by peavo
Modified: 2015-10-06 13:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.04 KB, patch)
2015-10-06 05:59 PDT, peavo
no flags Details | Formatted Diff | Diff
Patch (11.83 KB, patch)
2015-10-06 10:48 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-10-06 05:09:31 PDT
There are currently a few compile errors when compiling WinCairo with GStreamer:

InbandTextTrackPrivateGStreamer.cpp(86): error C2668: 'WTF::GThreadSafeMainLoopSource::schedule': ambiguous call to overloaded function
Comment 1 peavo 2015-10-06 05:59:11 PDT
Created attachment 262511 [details]
Patch
Comment 2 Zan Dobersek 2015-10-06 08:56:32 PDT
Comment on attachment 262511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262511&action=review

> Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:89
> -        [protector] { protector->notifyTrackOfSample(); });
> +        static_cast<std::function<void()>>(
> +            [protector] {
> +                protector->notifyTrackOfSample();
> +            }));

Just

    std::function<void ()>([protector] { ... })

should work, with no casts.
Comment 3 peavo 2015-10-06 10:48:32 PDT
Created attachment 262523 [details]
Patch
Comment 4 peavo 2015-10-06 10:49:42 PDT
(In reply to comment #2)
> Comment on attachment 262511 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262511&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:89
> > -        [protector] { protector->notifyTrackOfSample(); });
> > +        static_cast<std::function<void()>>(
> > +            [protector] {
> > +                protector->notifyTrackOfSample();
> > +            }));
> 
> Just
> 
>     std::function<void ()>([protector] { ... })
> 
> should work, with no casts.

Thanks, that's much better than my casts :)
Comment 5 peavo 2015-10-06 13:29:39 PDT
Thanks for reviewing, Alex!
Comment 6 WebKit Commit Bot 2015-10-06 13:45:38 PDT
Comment on attachment 262523 [details]
Patch

Clearing flags on attachment: 262523

Committed r190643: <http://trac.webkit.org/changeset/190643>
Comment 7 WebKit Commit Bot 2015-10-06 13:45:42 PDT
All reviewed patches have been landed.  Closing bug.