RESOLVED FIXED 149837
Binding generator should add builtin header for JSBuiltin attributes 
https://bugs.webkit.org/show_bug.cgi?id=149837
Summary Binding generator should add builtin header for JSBuiltin attributes
youenn fablet
Reported 2015-10-06 03:17:05 PDT
Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no longer needed. We should also handle JSBuiltin attributes similarly to JSBuiltin functions.
Attachments
Patch (11.37 KB, patch)
2015-10-06 04:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2015-10-06 03:43:41 PDT
(In reply to comment #0) > Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should > further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no > longer needed. > We should also handle JSBuiltin attributes similarly to JSBuiltin functions. Returning 1 is needed to break the loop.
youenn fablet
Comment 2 2015-10-06 04:49:13 PDT
Created attachment 262509 [details] Patch
youenn fablet
Comment 3 2015-10-06 04:52:20 PDT
(In reply to comment #1) > (In reply to comment #0) > > Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should > > further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no > > longer needed. > > We should also handle JSBuiltin attributes similarly to JSBuiltin functions. > > Returning 1 is needed to break the loop. Not breaking the loop has the slight benefit of being able to handle different Conditionals. I updated TestObj.idl to show this in the binding tests.
Xabier Rodríguez Calvar
Comment 4 2015-10-06 07:25:59 PDT
(In reply to comment #3) > (In reply to comment #1) > > (In reply to comment #0) > > > Following on https://bugs.webkit.org/show_bug.cgi?id=149759, we should > > > further refactor AddIncludesForJSBuiltinMethods, since returning 1 is no > > > longer needed. > > > We should also handle JSBuiltin attributes similarly to JSBuiltin functions. > > > > Returning 1 is needed to break the loop. > > Not breaking the loop has the slight benefit of being able to handle > different Conditionals. > I updated TestObj.idl to show this in the binding tests. Understood.
WebKit Commit Bot
Comment 5 2015-10-06 09:50:53 PDT
Comment on attachment 262509 [details] Patch Clearing flags on attachment: 262509 Committed r190620: <http://trac.webkit.org/changeset/190620>
WebKit Commit Bot
Comment 6 2015-10-06 09:50:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.