Bug 149822 - [iOS] REGRESSION(r190434): Media continues to play when locking screen
Summary: [iOS] REGRESSION(r190434): Media continues to play when locking screen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-05 15:48 PDT by Jer Noble
Modified: 2015-10-05 21:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (18.35 KB, patch)
2015-10-05 16:05 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-10-05 15:48:50 PDT 
[iOS] REGRESSION(r190434): Media continues to play when locking screen
Comment 1 Jer Noble 2015-10-05 16:05:05 PDT 
Created attachment 262475 [details]
Patch
Comment 2 Brent Fulgham 2015-10-05 16:44:04 PDT 
Comment on attachment 262475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262475&action=review

This change looks good. It would be even better if we had a test that locking the device during playback (with and without air-play) did the right thing. Do we have such a test? If not, could you at least file a bug to remind us to create that test?

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:280
> +    Vector<PlatformMediaSession*> sessions = this->sessions();

You could use auto here, but that's taste-specific.
Comment 3 WebKit Commit Bot 2015-10-05 21:14:02 PDT 
Comment on attachment 262475 [details]
Patch

Clearing flags on attachment: 262475

Committed r190604: <http://trac.webkit.org/changeset/190604>
Comment 4 WebKit Commit Bot 2015-10-05 21:14:07 PDT 
All reviewed patches have been landed.  Closing bug.