Bug 149820 – WebCore::IOSurface should ask the IOSurface for the pixel format instead of caching it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

WebCore::IOSurface should ask the IOSurface for the pixel format instead of caching it

[Beth Dakin]

Created attachment 262470 [details]
Patch

[Beth Dakin]

Created attachment 262472 [details]
Patch

[Tim Horton]

Comment on attachment 262470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262470&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:242
> +    if (pixelFormat == 'BGRA')
> +        return Format::RGBA;

I wonder if we should call the format BGRA since that's what it really is

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:243
> +#if PLATFORM(IOS)

Why is this (and the other yuv stuff) iOS specific? Only the transform part should be iOS specific.

That will fix your build error, too.

[Beth Dakin]

(In reply to comment #3)
> Comment on attachment 262470 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262470&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:242
> > +    if (pixelFormat == 'BGRA')
> > +        return Format::RGBA;
> 
> I wonder if we should call the format BGRA since that's what it really is
> 

NOOOOOOOOO

> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:243
> > +#if PLATFORM(IOS)
> 
> Why is this (and the other yuv stuff) iOS specific? Only the transform part
> should be iOS specific.
> 
> That will fix your build error, too.
 
Okay!

[Beth Dakin]

Created attachment 262476 [details]
Patch

[Beth Dakin]

Thanks Tim! 

http://trac.webkit.org/changeset/190587