WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149819
Marking compositing/video/video-poster.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=149819
Summary
Marking compositing/video/video-poster.html as flaky
Ryan Haddad
Reported
2015-10-05 15:36:37 PDT
The following layout test is flaky on El Capitan Debug WK2, crashes every few builds. compositing/video/video-poster.html
http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fvideo%2Fvideo-poster.html
Attachments
Patch
(2.19 KB, patch)
2015-10-05 15:43 PDT
,
Ryan Haddad
no flags
Details
Formatted Diff
Diff
Patch
(2.20 KB, patch)
2015-10-05 16:12 PDT
,
Ryan Haddad
no flags
Details
Formatted Diff
Diff
Patch
(2.77 KB, patch)
2015-10-06 11:12 PDT
,
Ryan Haddad
no flags
Details
Formatted Diff
Diff
Patch
(2.78 KB, patch)
2015-10-06 11:42 PDT
,
Ryan Haddad
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2015-10-05 15:37:46 PDT
This is actually a bad bug in the underlying frameworks.
Ryan Haddad
Comment 2
2015-10-05 15:40:14 PDT
<
rdar://problem/16622896
>
Ryan Haddad
Comment 3
2015-10-05 15:43:17 PDT
Created
attachment 262471
[details]
Patch
Simon Fraser (smfr)
Comment 4
2015-10-05 16:06:02 PDT
Comment on
attachment 262471
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=262471&action=review
> LayoutTests/ChangeLog:7 > + Unreviewed test gardening.
But it is reviewed!
> LayoutTests/platform/mac-elcapitan/TestExpectations:2 > +# to the Apple Mac port running El Capitan (DumpRenderTree)
This is the generic Mac TestExpectations, so not just limited to DumpRenderTree. You can remove the "(DumpRenderTree)".
Ryan Haddad
Comment 5
2015-10-05 16:12:28 PDT
Created
attachment 262477
[details]
Patch
Ryan Haddad
Comment 6
2015-10-05 16:13:11 PDT
Patch updated with suggested changes. Thanks!
WebKit Commit Bot
Comment 7
2015-10-05 16:36:42 PDT
Comment on
attachment 262477
[details]
Patch Clearing flags on attachment: 262477 Committed
r190590
: <
http://trac.webkit.org/changeset/190590
>
WebKit Commit Bot
Comment 8
2015-10-05 16:36:46 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 9
2015-10-06 11:09:11 PDT
Did not land expectations properly. Reopening.
Ryan Haddad
Comment 10
2015-10-06 11:12:37 PDT
Created
attachment 262528
[details]
Patch
Alexey Proskuryakov
Comment 11
2015-10-06 11:20:05 PDT
Comment on
attachment 262528
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=262528&action=review
> LayoutTests/platform/mac/TestExpectations:1336 > +
webkit.org/b/149819
[ ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]
I think that it's a debug assertion, so you also want a Debug qualifier:
webkit.org/b/149819
[ Debug ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]
Ryan Haddad
Comment 12
2015-10-06 11:42:36 PDT
Created
attachment 262530
[details]
Patch
WebKit Commit Bot
Comment 13
2015-10-06 13:44:07 PDT
Comment on
attachment 262530
[details]
Patch Clearing flags on attachment: 262530 Committed
r190642
: <
http://trac.webkit.org/changeset/190642
>
WebKit Commit Bot
Comment 14
2015-10-06 13:44:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug