Bug 149819 - Marking compositing/video/video-poster.html as flaky
Summary: Marking compositing/video/video-poster.html as flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac OS X 10.11
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-05 15:36 PDT by Ryan Haddad
Modified: 2015-10-06 13:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2015-10-05 15:43 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2015-10-05 16:12 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2015-10-06 11:12 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (2.78 KB, patch)
2015-10-06 11:42 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2015-10-05 15:36:37 PDT 
The following layout test is flaky on El Capitan Debug WK2, crashes every few builds.

compositing/video/video-poster.html

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fvideo%2Fvideo-poster.html
Comment 1 Simon Fraser (smfr) 2015-10-05 15:37:46 PDT 
This is actually a bad bug in the underlying frameworks.
Comment 2 Ryan Haddad 2015-10-05 15:40:14 PDT 
<rdar://problem/16622896>
Comment 3 Ryan Haddad 2015-10-05 15:43:17 PDT 
Created attachment 262471 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-10-05 16:06:02 PDT 
Comment on attachment 262471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262471&action=review

> LayoutTests/ChangeLog:7
> +        Unreviewed test gardening.

But it is reviewed!

> LayoutTests/platform/mac-elcapitan/TestExpectations:2
> +# to the Apple Mac port running El Capitan (DumpRenderTree)

This is the generic Mac TestExpectations, so not just limited to DumpRenderTree. You can remove the "(DumpRenderTree)".
Comment 5 Ryan Haddad 2015-10-05 16:12:28 PDT 
Created attachment 262477 [details]
Patch
Comment 6 Ryan Haddad 2015-10-05 16:13:11 PDT 
Patch updated with suggested changes. Thanks!
Comment 7 WebKit Commit Bot 2015-10-05 16:36:42 PDT 
Comment on attachment 262477 [details]
Patch

Clearing flags on attachment: 262477

Committed r190590: <http://trac.webkit.org/changeset/190590>
Comment 8 WebKit Commit Bot 2015-10-05 16:36:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Ryan Haddad 2015-10-06 11:09:11 PDT 
Did not land expectations properly. Reopening.
Comment 10 Ryan Haddad 2015-10-06 11:12:37 PDT 
Created attachment 262528 [details]
Patch
Comment 11 Alexey Proskuryakov 2015-10-06 11:20:05 PDT 
Comment on attachment 262528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262528&action=review

> LayoutTests/platform/mac/TestExpectations:1336
> +webkit.org/b/149819 [ ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]

I think that it's a debug assertion, so you also want a Debug qualifier:

webkit.org/b/149819 [ Debug ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]
Comment 12 Ryan Haddad 2015-10-06 11:42:36 PDT 
Created attachment 262530 [details]
Patch
Comment 13 WebKit Commit Bot 2015-10-06 13:44:07 PDT 
Comment on attachment 262530 [details]
Patch

Clearing flags on attachment: 262530

Committed r190642: <http://trac.webkit.org/changeset/190642>
Comment 14 WebKit Commit Bot 2015-10-06 13:44:11 PDT 
All reviewed patches have been landed.  Closing bug.