Bug 149818 - Disable Bitcode when building for iOS device
Summary: Disable Bitcode when building for iOS device
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 9.0
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 140828
Blocks:
  Show dependency tree / graph
 
Reported: 2015-10-05 14:58 PDT by Daniel Bates
Modified: 2015-10-05 15:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2015-10-05 15:00 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-10-05 14:58:03 PDT 
Do not generate bitcode when building for iOS device. Xcode 7 generates bitcode for iOS device apps by default.
Comment 1 Daniel Bates 2015-10-05 14:59:36 PDT 
With the patch for bug #140828, running build-webkit --debug --device eventually fails with the following message:

ld: -unexported_symbol and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together
Comment 2 Daniel Bates 2015-10-05 15:00:26 PDT 
Created attachment 262465 [details]
Patch
Comment 3 Alexey Proskuryakov 2015-10-05 15:14:10 PDT 
Comment on attachment 262465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262465&action=review

> Tools/ChangeLog:9
> +        Xcode 7 generates bitcode for iOS device apps by default. For now, do not generate bitcode
> +        when building for iOS device.

Why is it "for now"? Not sure why we'd need that for a system framework.
Comment 4 Daniel Bates 2015-10-05 15:26:59 PDT 
(In reply to comment #3)
> Comment on attachment 262465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262465&action=review
> 
> > Tools/ChangeLog:9
> > +        Xcode 7 generates bitcode for iOS device apps by default. For now, do not generate bitcode
> > +        when building for iOS device.
> 
> Why is it "for now"? Not sure why we'd need that for a system framework.

We do not need it. Will remove the phrase "For now".
Comment 5 Daniel Bates 2015-10-05 15:36:25 PDT 
Committed r190584: <http://trac.webkit.org/changeset/190584>