Bug 149813 - [Win] Clean up annoying compiler warnings
Summary: [Win] Clean up annoying compiler warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-05 11:23 PDT by Brent Fulgham
Modified: 2016-05-10 07:34 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.39 KB, patch)
2016-05-01 23:29 PDT, peavo 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-10-05 11:23:22 PDT 
The Windows build log is cluttered with build warnings that make it difficult to find real problems during the build.

Could you please correct these warnings so we can get a meaningful build log?

[53/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\Error.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\runtime\error.cpp(170) : warning C4701: potentially uninitialized local variable 'stackFrame' used
c:\projects\webkit\opensource\source\javascriptcore\runtime\error.cpp(170) : warning C4703: potentially uninitialized local pointer variable 'stackFrame' used
[61/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\ErrorInstance.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\runtime\errorinstance.cpp(160) : warning C4701: potentially uninitialized local variable 'stackFrame' used
c:\projects\webkit\opensource\source\javascriptcore\runtime\errorinstance.cpp(160) : warning C4703: potentially uninitialized local pointer variable 'stackFrame' used
[177/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\RegExpPrototype.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\runtime\regexpprototype.cpp(148) : warning C4700: uninitialized local variable 'string' used
[216/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\VM.cpp.obj
..\..\Source\JavaScriptCore\runtime\VM.cpp(338): warning C4312: 'reinterpret_cast': conversion from 'unsigned int' to 'JSC::Interpreter *' of greater size
[306/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\bytecode\PropertyCondition.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\bytecode\propertycondition.cpp(256) : warning C4701: potentially uninitialized local variable 'set' used
c:\projects\webkit\opensource\source\javascriptcore\bytecode\propertycondition.cpp(256) : warning C4703: potentially uninitialized local pointer variable 'set' used
[434/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGObjectAllocationSinkingPhase.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgobjectallocationsinkingphase.cpp(1400) : warning C4701: potentially uninitialized local variable 'bestAllocation' used
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgobjectallocationsinkingphase.cpp(1400) : warning C4703: potentially uninitialized local pointer variable 'bestAllocation' used
[451/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGSpeculativeJIT64.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgspeculativejit64.cpp(823) : warning C4701: potentially uninitialized local variable 'calleeGPR' used
[456/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGSpeculativeJIT.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgspeculativejit.cpp(4744) : warning C4701: potentially uninitialized local variable 'thisValueGPR' used
[548/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\jit\JITCall.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\jit\jitcall.cpp(189) : warning C4701: potentially uninitialized local variable 'info' used
c:\projects\webkit\opensource\source\javascriptcore\jit\jitcall.cpp(189) : warning C4703: potentially uninitialized local pointer variable 'info' used
[551/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\parser\Parser.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
[597/1109] Building CXX object Source\JavaScriptCore\shell\CMakeFiles\jscLib.dir\__\jsc.cpp.obj
..\..\Source\JavaScriptCore\jsc.cpp(1332): warning C4646: function declared with __declspec(noreturn) has non-void return type
Comment 1 peavo 2016-05-01 23:29:53 PDT 
Created attachment 277893 [details]
Patch
Comment 2 Alex Christensen 2016-05-02 00:11:34 PDT 
Comment on attachment 277893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277893&action=review

> Source/JavaScriptCore/runtime/RegExpPrototype.cpp:178
> +    string[0] = 0;

This adds an unnecessary operation in the common case where no error happens.  Could we add this only if we are returning early?

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:678
> -        return -1;
> +        return UINT_MAX;

We typically use std::numeric_limits<unsigned>::max()
Comment 3 peavo 2016-05-02 14:22:33 PDT 
Thanks for reviewing :)
Comment 4 peavo 2016-05-02 14:25:06 PDT 
Committed r200338: <http://trac.webkit.org/changeset/200338>