Bug 149813 – [Win] Clean up annoying compiler warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Brent Fulgham]

The Windows build log is cluttered with build warnings that make it difficult to find real problems during the build.

Could you please correct these warnings so we can get a meaningful build log?

[53/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\Error.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\runtime\error.cpp(170) : warning C4701: potentially uninitialized local variable 'stackFrame' used
c:\projects\webkit\opensource\source\javascriptcore\runtime\error.cpp(170) : warning C4703: potentially uninitialized local pointer variable 'stackFrame' used
[61/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\ErrorInstance.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\runtime\errorinstance.cpp(160) : warning C4701: potentially uninitialized local variable 'stackFrame' used
c:\projects\webkit\opensource\source\javascriptcore\runtime\errorinstance.cpp(160) : warning C4703: potentially uninitialized local pointer variable 'stackFrame' used
[177/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\RegExpPrototype.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\runtime\regexpprototype.cpp(148) : warning C4700: uninitialized local variable 'string' used
[216/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\VM.cpp.obj
..\..\Source\JavaScriptCore\runtime\VM.cpp(338): warning C4312: 'reinterpret_cast': conversion from 'unsigned int' to 'JSC::Interpreter *' of greater size
[306/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\bytecode\PropertyCondition.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\bytecode\propertycondition.cpp(256) : warning C4701: potentially uninitialized local variable 'set' used
c:\projects\webkit\opensource\source\javascriptcore\bytecode\propertycondition.cpp(256) : warning C4703: potentially uninitialized local pointer variable 'set' used
[434/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGObjectAllocationSinkingPhase.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgobjectallocationsinkingphase.cpp(1400) : warning C4701: potentially uninitialized local variable 'bestAllocation' used
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgobjectallocationsinkingphase.cpp(1400) : warning C4703: potentially uninitialized local pointer variable 'bestAllocation' used
[451/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGSpeculativeJIT64.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgspeculativejit64.cpp(823) : warning C4701: potentially uninitialized local variable 'calleeGPR' used
[456/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGSpeculativeJIT.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgspeculativejit.cpp(4744) : warning C4701: potentially uninitialized local variable 'thisValueGPR' used
[548/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\jit\JITCall.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\jit\jitcall.cpp(189) : warning C4701: potentially uninitialized local variable 'info' used
c:\projects\webkit\opensource\source\javascriptcore\jit\jitcall.cpp(189) : warning C4703: potentially uninitialized local pointer variable 'info' used
[551/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\parser\Parser.cpp.obj
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used
c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used
[597/1109] Building CXX object Source\JavaScriptCore\shell\CMakeFiles\jscLib.dir\__\jsc.cpp.obj
..\..\Source\JavaScriptCore\jsc.cpp(1332): warning C4646: function declared with __declspec(noreturn) has non-void return type

Created attachment 277893 [details]
Patch

[Alex Christensen]

Comment on attachment 277893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277893&action=review

> Source/JavaScriptCore/runtime/RegExpPrototype.cpp:178
> +    string[0] = 0;

This adds an unnecessary operation in the common case where no error happens.  Could we add this only if we are returning early?

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:678
> -        return -1;
> +        return UINT_MAX;

We typically use std::numeric_limits<unsigned>::max()

Thanks for reviewing :)

Committed r200338: <http://trac.webkit.org/changeset/200338>