Bug 149812 – Support webkit-test-runner key-value pairs in http tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Support webkit-test-runner key-value pairs in http tests

[Alex Christensen]

Created attachment 262449 [details]
Patch

[Build Bot]

Comment on attachment 262449 [details]
Patch

Attachment 262449 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/247314

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 262452 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Alexey Proskuryakov]

Comment on attachment 262449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262449&action=review

> Tools/ChangeLog:9
> +        But with http tests, we do not want to send a request to the local server to get this metadata so we do not

This sounds very familiar, don't we already have a code path that does the same?

[Alex Christensen]

(In reply to comment #4)
> Comment on attachment 262449 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262449&action=review
> 
> > Tools/ChangeLog:9
> > +        But with http tests, we do not want to send a request to the local server to get this metadata so we do not
> 
> This sounds very familiar, don't we already have a code path that does the
> same?
I was not aware of one.  The only way I'm aware of is getting a command line parameter from python, but if there is another way I'd love to hear it.

[Alexey Proskuryakov]

Anders or Myles would know for sure.

[Myles C. Maxfield]

(In reply to comment #6)
> Anders or Myles would know for sure.

I am also not aware of one.

[Myles C. Maxfield]

I think this is a good thing. If you got it working, I would r+ it.

[Antoine Quint]

*** Bug 166331 has been marked as a duplicate of this bug. ***

[Antoine Quint]

<rdar://problem/29772341>

[Antoine Quint]

Created attachment 298184 [details]
Patch

[Build Bot]

Comment on attachment 298184 [details]
Patch

Attachment 298184 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842749

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298186 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298184 [details]
Patch

Attachment 298184 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842754

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 298188 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 298189 [details]
Patch

[Antoine Quint]

Created attachment 298198 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 298198 [details]
Patch

Clearing flags on attachment: 298198

Committed r210446: <http://trac.webkit.org/changeset/210446>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antoine Quint]

Followup work for WK1 is at https://bugs.webkit.org/show_bug.cgi?id=166837.