Bug 149812 - Support webkit-test-runner key-value pairs in http tests
Summary: Support webkit-test-runner key-value pairs in http tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 166331 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-10-05 11:12 PDT by Alex Christensen
Modified: 2017-01-09 04:17 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.68 KB, patch)
2015-10-05 11:22 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (734.93 KB, application/zip)
2015-10-05 11:54 PDT, Build Bot 		no flags Details
Patch (6.15 KB, patch)
2017-01-06 01:45 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (789.65 KB, application/zip)
2017-01-06 02:33 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (935.17 KB, application/zip)
2017-01-06 02:42 PST, Build Bot 		no flags Details
Patch (6.91 KB, patch)
2017-01-06 02:45 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (7.20 KB, patch)
2017-01-06 05:53 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-10-05 11:12:47 PDT 
Support webkit-test-runner key-value pairs in http tests
Comment 1 Alex Christensen 2015-10-05 11:22:22 PDT 
Created attachment 262449 [details]
Patch
Comment 2 Build Bot 2015-10-05 11:54:30 PDT 
Comment on attachment 262449 [details]
Patch

Attachment 262449 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/247314

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-10-05 11:54:33 PDT 
Created attachment 262452 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Alexey Proskuryakov 2015-10-05 19:07:13 PDT 
Comment on attachment 262449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262449&action=review

> Tools/ChangeLog:9
> +        But with http tests, we do not want to send a request to the local server to get this metadata so we do not

This sounds very familiar, don't we already have a code path that does the same?
Comment 5 Alex Christensen 2015-10-05 19:18:02 PDT 
(In reply to comment #4)
> Comment on attachment 262449 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262449&action=review
> 
> > Tools/ChangeLog:9
> > +        But with http tests, we do not want to send a request to the local server to get this metadata so we do not
> 
> This sounds very familiar, don't we already have a code path that does the
> same?
I was not aware of one.  The only way I'm aware of is getting a command line parameter from python, but if there is another way I'd love to hear it.
Comment 6 Alexey Proskuryakov 2015-10-06 08:58:20 PDT 
Anders or Myles would know for sure.
Comment 7 Myles C. Maxfield 2015-10-06 13:19:01 PDT 
(In reply to comment #6)
> Anders or Myles would know for sure.

I am also not aware of one.
Comment 8 Myles C. Maxfield 2016-10-03 22:50:05 PDT 
I think this is a good thing. If you got it working, I would r+ it.
Comment 9 Antoine Quint 2017-01-05 11:31:51 PST 
*** Bug 166331 has been marked as a duplicate of this bug. ***
Comment 10 Antoine Quint 2017-01-05 11:32:35 PST 
<rdar://problem/29772341>
Comment 11 Antoine Quint 2017-01-06 01:45:25 PST 
Created attachment 298184 [details]
Patch
Comment 12 Build Bot 2017-01-06 02:33:18 PST 
Comment on attachment 298184 [details]
Patch

Attachment 298184 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842749

Number of test failures exceeded the failure limit.
Comment 13 Build Bot 2017-01-06 02:33:22 PST 
Created attachment 298186 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-01-06 02:42:32 PST 
Comment on attachment 298184 [details]
Patch

Attachment 298184 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2842754

Number of test failures exceeded the failure limit.
Comment 15 Build Bot 2017-01-06 02:42:36 PST 
Created attachment 298188 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 16 Antoine Quint 2017-01-06 02:45:13 PST 
Created attachment 298189 [details]
Patch
Comment 17 Antoine Quint 2017-01-06 05:53:32 PST 
Created attachment 298198 [details]
Patch
Comment 18 WebKit Commit Bot 2017-01-06 10:51:16 PST 
Comment on attachment 298198 [details]
Patch

Clearing flags on attachment: 298198

Committed r210446: <http://trac.webkit.org/changeset/210446>
Comment 19 WebKit Commit Bot 2017-01-06 10:51:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 20 Antoine Quint 2017-01-09 04:17:53 PST 
Followup work for WK1 is at https://bugs.webkit.org/show_bug.cgi?id=166837.