[css-grid] Percentages of indefinite sizes to be resolved as auto
Created attachment 262506 [details] Patch
Comment on attachment 262506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262506&action=review > Source/WebCore/rendering/RenderGrid.cpp:563 > + static NeverDestroyed<GridLength> autoLength((Length(Auto))); Why the global variable?
Comment on attachment 262506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262506&action=review >> Source/WebCore/rendering/RenderGrid.cpp:563 >> + static NeverDestroyed<GridLength> autoLength((Length(Auto))); > > Why the global variable? No special reason, just to avoid creating it over and over again, but not strong feelings about it.
Created attachment 262591 [details] Patch Removed the global variable and the extra include
Created attachment 262689 [details] Patch for landing
Comment on attachment 262689 [details] Patch for landing Rejecting attachment 262689 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 262689, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/257292
Created attachment 262690 [details] Patch for landing
Created attachment 262691 [details] Patch for landing
Comment on attachment 262691 [details] Patch for landing Clearing flags on attachment: 262691 Committed r190721: <http://trac.webkit.org/changeset/190721>
All reviewed patches have been landed. Closing bug.