Bug 149803 - Remove unused HistoryItem::parent
Summary: Remove unused HistoryItem::parent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-05 06:04 PDT by Andreas Kling
Modified: 2015-10-05 07:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.17 KB, patch)
2015-10-05 06:17 PDT, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
Patch for landing (8.09 KB, patch)
2015-10-05 06:46 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-10-05 06:04:16 PDT 
The HistoryItem::m_parent field appears to be unused, so let's try and remove it.
Comment 1 Andreas Kling 2015-10-05 06:17:52 PDT 
Created attachment 262429 [details]
Patch
Comment 2 Andreas Kling 2015-10-05 06:19:59 PDT 
Comment on attachment 262429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262429&action=review

> Source/WebCore/history/HistoryItem.h:213
> -    WEBCORE_EXPORT HistoryItem(const URL&, const String& frameName, const String& parent, const String& title);
> +    WEBCORE_EXPORT HistoryItem(const URL&, const String& frameName, const String& title);

Oops, this should be removed as well.
Comment 3 Andreas Kling 2015-10-05 06:46:48 PDT 
Created attachment 262431 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2015-10-05 07:39:20 PDT 
Comment on attachment 262431 [details]
Patch for landing

Clearing flags on attachment: 262431

Committed r190559: <http://trac.webkit.org/changeset/190559>
Comment 5 WebKit Commit Bot 2015-10-05 07:39:24 PDT 
All reviewed patches have been landed.  Closing bug.