Bug 149800 - [css-grid] Implement grid gutters
Summary: [css-grid] Implement grid gutters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2015-10-05 01:15 PDT by Sergio Villar Senin
Modified: 2015-10-07 02:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (89.52 KB, patch)
2015-10-05 01:37 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (88.86 KB, patch)
2015-10-05 08:09 PDT, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2015-10-05 01:15:37 PDT 
[css-grid] Implement grid gutters
Comment 1 Sergio Villar Senin 2015-10-05 01:30:21 PDT 
Citing the specs

    "These properties specify the gutters between grid rows and grid columns, respectively. The effect is as though the affected grid lines acquired width: the grid track between two grid lines is the space between the gutters that represent them."
Comment 2 Sergio Villar Senin 2015-10-05 01:37:46 PDT 
Created attachment 262421 [details]
Patch
Comment 3 Sergio Villar Senin 2015-10-05 08:09:31 PDT 
Created attachment 262437 [details]
Patch

removed normal as a valid keyword
Comment 4 Darin Adler 2015-10-06 08:38:48 PDT 
Comment on attachment 262437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262437&action=review

> Source/WebCore/rendering/style/StyleGridData.h:51
>          // FIXME: comparing two hashes doesn't look great for performance. Something to keep in mind going forward.

I don’t understand this comment. Where is the code comparing two hashes?

> Source/WebCore/rendering/style/StyleGridData.h:58
> +        return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows
> +        && m_gridAutoFlow == o.m_gridAutoFlow && m_gridAutoRows == o.m_gridAutoRows && m_gridAutoColumns == o.m_gridAutoColumns
> +        && m_namedGridColumnLines == o.m_namedGridColumnLines && m_namedGridRowLines == o.m_namedGridRowLines
> +        && m_namedGridArea == o.m_namedGridArea && m_namedGridArea == o.m_namedGridArea
> +        && m_namedGridAreaRowCount == o.m_namedGridAreaRowCount && m_namedGridAreaColumnCount == o.m_namedGridAreaColumnCount
> +        && m_orderedNamedGridRowLines == o.m_orderedNamedGridRowLines && m_orderedNamedGridColumnLines == o.m_orderedNamedGridColumnLines
> +        && m_gridColumnGap == o.m_gridColumnGap && m_gridRowGap == o.m_gridRowGap;

WebKit coding style would have the && indented by four spaces on subsequent lines.
Comment 5 Sergio Villar Senin 2015-10-07 01:40:39 PDT 
Comment on attachment 262437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262437&action=review

>> Source/WebCore/rendering/style/StyleGridData.h:51
>>          // FIXME: comparing two hashes doesn't look great for performance. Something to keep in mind going forward.
> 
> I don’t understand this comment. Where is the code comparing two hashes?

Some of those structures are hashmaps.

>> Source/WebCore/rendering/style/StyleGridData.h:58
>> +        && m_gridColumnGap == o.m_gridColumnGap && m_gridRowGap == o.m_gridRowGap;
> 
> WebKit coding style would have the && indented by four spaces on subsequent lines.

Not sure why it has this weird indentation, I'll fix it.
Comment 6 Sergio Villar Senin 2015-10-07 02:41:21 PDT 
Committed r190663: <http://trac.webkit.org/changeset/190663>