Bug 149799 - Web Inspector: Error displayed as an object when passed as a second argument to console.log
Summary: Web Inspector: Error displayed as an object when passed as a second argument ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-04 20:19 PDT by Nikita Vasilyev
Modified: 2015-10-05 13:01 PDT (History)
8 users (show)

See Also:

Attachments
[Image] Bug (98.66 KB, image/png)
2015-10-04 20:19 PDT, Nikita Vasilyev 		no flags Details
WIP (226.64 KB, patch)
2015-10-04 21:16 PDT, Nikita Vasilyev 		nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (5.76 KB, patch)
2015-10-05 07:47 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] With the patch applied (327.80 KB, image/gif)
2015-10-05 07:56 PDT, Nikita Vasilyev 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-10-04 20:19:36 PDT 
Created attachment 262414 [details]
[Image] Bug

try {
    bar();
} catch(error) {
    console.log(error);
    console.log("prefix", error);
}

Expected:
Both errors rendered using ErrorObjectView.

Actual:
console.log("prefix", error) shows an error as an object outline.
Comment 1 Radar WebKit Bug Importer 2015-10-04 20:19:49 PDT 
<rdar://problem/22967701>
Comment 2 Nikita Vasilyev 2015-10-04 21:16:40 PDT 
Created attachment 262417 [details]
WIP
Comment 3 Nikita Vasilyev 2015-10-05 07:47:18 PDT 
Created attachment 262433 [details]
Patch
Comment 4 Nikita Vasilyev 2015-10-05 07:56:09 PDT 
Created attachment 262434 [details]
[Animated GIF] With the patch applied
Comment 5 Joseph Pecoraro 2015-10-05 12:15:41 PDT 
Comment on attachment 262433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262433&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:506
> +        const fragment = document.createDocumentFragment();

Maybe its just me, but I think `let` is better than `const` in some of these cases.
Comment 6 WebKit Commit Bot 2015-10-05 13:00:54 PDT 
Comment on attachment 262433 [details]
Patch

Clearing flags on attachment: 262433

Committed r190571: <http://trac.webkit.org/changeset/190571>
Comment 7 WebKit Commit Bot 2015-10-05 13:01:01 PDT 
All reviewed patches have been landed.  Closing bug.