Bug 149785 - CodeBlock.h shouldn't be included from everywhere
Summary: CodeBlock.h shouldn't be included from everywhere
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-03 15:59 PDT by Filip Pizlo
Modified: 2016-02-02 17:29 PST (History)
12 users (show)

See Also:

Attachments
Patch (15.34 KB, patch)
2015-10-03 16:00 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-10-03 15:59:50 PDT 
CodeBlock.h shouldn't be included from everywhere
Comment 1 Filip Pizlo 2015-10-03 16:00:29 PDT 
Created attachment 262383 [details]
Patch
Comment 2 Filip Pizlo 2015-10-04 12:35:04 PDT 
Comment on attachment 262383 [details]
Patch

Actually, I will land myself.  I'll also try to make this more robust by making CodeBlock.h into a Project header so WebCore cannot include it.
Comment 3 Filip Pizlo 2015-10-04 15:40:22 PDT 
Comment on attachment 262383 [details]
Patch

OK, I'll let commit-queue land it.  I was trying to remove a bunch of headers, including CodeBlock.h, from the Private headers list.  But it turns out that there is some test support code in WebCore that includes CodeBlock.h directly.  Removing that dependency didn't seem like an easy task.

So, CodeBlock.h can still be included from anywhere, but at least it's no longer included from everywhere.
Comment 4 WebKit Commit Bot 2015-10-04 16:26:14 PDT 
Comment on attachment 262383 [details]
Patch

Clearing flags on attachment: 262383

Committed r190555: <http://trac.webkit.org/changeset/190555>
Comment 5 WebKit Commit Bot 2015-10-04 16:26:18 PDT 
All reviewed patches have been landed.  Closing bug.