RESOLVED FIXED 149777
Test font-variant-* and font-feature-settings with mocked preinstalled fonts
https://bugs.webkit.org/show_bug.cgi?id=149777
Summary Test font-variant-* and font-feature-settings with mocked preinstalled fonts
Myles C. Maxfield
Reported 2015-10-02 16:58:56 PDT
We should use the same mechanism that we use for WebKitWeightWatcher to mock installing a font for tests. Then, we can test font features on preinstalled fonts.
Attachments
Patch (655.24 KB, patch)
2015-10-10 20:54 PDT, Myles C. Maxfield
no flags
Archive of layout-test-results from ews102 for mac-mavericks (771.05 KB, application/zip)
2015-10-10 21:27 PDT, Build Bot
no flags
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (827.50 KB, application/zip)
2015-10-10 21:32 PDT, Build Bot
no flags
Patch (658.14 KB, patch)
2015-10-10 22:20 PDT, Myles C. Maxfield
simon.fraser: review+
Radar WebKit Bug Importer
Comment 1 2015-10-02 17:07:22 PDT
Myles C. Maxfield
Comment 2 2015-10-10 20:54:20 PDT
Build Bot
Comment 3 2015-10-10 21:27:11 PDT
Comment on attachment 262845 [details] Patch Attachment 262845 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/266740 New failing tests: css3/font-variant-all.html
Build Bot
Comment 4 2015-10-10 21:27:15 PDT
Created attachment 262847 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-10-10 21:32:54 PDT
Comment on attachment 262845 [details] Patch Attachment 262845 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/266746 New failing tests: css3/font-variant-all.html
Build Bot
Comment 6 2015-10-10 21:32:57 PDT
Created attachment 262848 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Myles C. Maxfield
Comment 7 2015-10-10 22:02:32 PDT
I need to update TestExpectations.
Myles C. Maxfield
Comment 8 2015-10-10 22:20:33 PDT
Simon Fraser (smfr)
Comment 9 2015-10-11 10:48:02 PDT
Comment on attachment 262851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262851&action=review > Tools/FontWithFeatures/FontWithFeatures/main.cpp:129 > - std::ofstream outputFile("/Volumes/Data/home/mmaxfield/tmp/output.ttf", std::ios::out | std::ios::binary); > + std::ofstream outputFile("/Volumes/Data/home/mmaxfield/src/WebKit/OpenSource/LayoutTests/css3/resources/FontWithFeatures.ttf", std::ios::out | std::ios::binary); It's wrong to have a hard-coded path that only works on your machine here.
Myles C. Maxfield
Comment 10 2015-10-11 13:24:01 PDT
Daniel Bates
Comment 11 2015-10-13 20:24:22 PDT
(In reply to comment #10) > Committed r190848: <http://trac.webkit.org/changeset/190848> This changes prevents us from running tests as iOS DumpRenderTree exits with error "Failed to create CGFontRef for the FontWithFeaturesTTF font": <https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK1%20(Tests)/r191029%20(324)/results.html>
Myles C. Maxfield
Comment 12 2015-10-14 09:45:34 PDT
(In reply to comment #11) > (In reply to comment #10) > > Committed r190848: <http://trac.webkit.org/changeset/190848> > > This changes prevents us from running tests as iOS DumpRenderTree exits with > error "Failed to create CGFontRef for the FontWithFeaturesTTF font": > > <https://build.webkit.org/results/ > Apple%20iOS%209%20Simulator%20Release%20WK1%20(Tests)/r191029%20(324)/ > results.html> http://trac.webkit.org/changeset/191032 fixes this.
Note You need to log in before you can comment on or make changes to this bug.