Allow WKRetainPtrs to be used as keys in hashing data structures
*** Bug 149763 has been marked as a duplicate of this bug. ***
Created attachment 262353 [details] Patch
Comment on attachment 262353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262353&action=review > Tools/TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:40 > + WKRetainPtr<WKContextRef> context1 = adoptWK(WKContextCreate()); > + WKRetainPtr<WKContextRef> context2 = adoptWK(WKContextCreate()); > + WKRetainPtr<WKContextRef> context3 = adoptWK(WKContextCreate()); > + WKRetainPtr<WKContextRef> context4 = adoptWK(WKContextCreate()); I'd use WKStringRef here instead of WKContextRef, for two reasons: 1. WKContextRefs are expensive to make. 2. Using WKStringRefs with two identical strings will test that it's pointer equality and not value equality that's used when putting WKRetainPtrs in hash maps.
Committed r190572: <http://trac.webkit.org/changeset/190572>
Comment on attachment 262353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262353&action=review > Tools/TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:2 > + * Copyright (C) 2011 Apple Inc. All rights reserved. Surely the year is 2015.
(In reply to comment #6) > Comment on attachment 262353 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262353&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:2 > > + * Copyright (C) 2011 Apple Inc. All rights reserved. > > Surely the year is 2015. Committed r190639: <http://trac.webkit.org/changeset/190639>
Re-opened since this is blocked by bug 149897