Bug 149757 - Provide "--no-ninja" option to avoid using Ninja
Summary: Provide "--no-ninja" option to avoid using Ninja
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-02 11:08 PDT by Brent Fulgham
Modified: 2015-10-02 14:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2015-10-02 11:27 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2015-10-02 12:56 PDT, Brent Fulgham 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-10-02 11:08:45 PDT 
Now that we are using CMake, it's great to be able to use Ninja to do my daily builds. However, I sometimes need to regenerate a Visual Studio solution so that I can more easily navigate and edit the files in the solution.

Unfortunately, as soon as you install Ninja you are locked into that generator for building.

We need a "--no-ninja" argument so we can switch back and forth as needed.
Comment 1 Brent Fulgham 2015-10-02 11:27:59 PDT 
Created attachment 262343 [details]
Patch
Comment 2 Alex Christensen 2015-10-02 12:17:28 PDT 
Comment on attachment 262343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262343&action=review

> Tools/Scripts/webkitdirs.pm:1817
> +    return if ($shouldNotUseNinja);

I think this will return the opposite of what you intend.
Comment 3 Brent Fulgham 2015-10-02 12:56:05 PDT 
Created attachment 262347 [details]
Patch
Comment 4 Brent Fulgham 2015-10-02 14:44:34 PDT 
Committed r190524: <http://trac.webkit.org/changeset/190524>