Bug 149729 - Remove unnecessary SpecialFastCaseProfiles.
Summary: Remove unnecessary SpecialFastCaseProfiles.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 149600
  Show dependency treegraph
 
Reported: 2015-10-01 15:38 PDT by Mark Lam
Modified: 2015-10-01 16:22 PDT (History)
7 users (show)

See Also:


Attachments
the fix. (6.44 KB, patch)
2015-10-01 15:45 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-10-01 15:38:35 PDT
The current baseline code creates special fast case profiles records for bytecodes that don't need them.  This was done to keep the DFG from crashing when it searches for such a profile and don't find one.  Instead, we should fix the code to check for the existence of the profile before dereferencing it to get a count.
Comment 1 Mark Lam 2015-10-01 15:45:54 PDT
Created attachment 262293 [details]
the fix.
Comment 2 Saam Barati 2015-10-01 15:59:16 PDT
Comment on attachment 262293 [details]
the fix.

r=me
Comment 3 Mark Lam 2015-10-01 16:22:38 PDT
Thanks.  Landed in r190435: <http://trac.webkit.org/r190435>.