Bug 149725 – Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 262286 [details]
[Image] Collapsed toolbar

* SUMMARY
Toolbar collapses when inspector at minimum height with console open. It's easier to reproduce with the inspector docked at the bottom. 

* STEPS TO REPRODUCE
1. Open Inspector > any tab except Console
2. Expand the console, drag to maximum height
3. Decrease inspector window height to the minimum height
  => Toolbar and tab bar collapse rather than stopping once the top of the console is hit

*NOTES
Regressed in http://trac.webkit.org/changeset/189567.

The patch changed the min-width/height defaults to auto for flex box items. Per the patch notes, we should be setting:

min-width: 0;
min-height: 0;

for any flex items.

[Radar WebKit Bug Importer]

<rdar://problem/22941366>

[Matt Baker]

Created attachment 262287 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 262287 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=262287&action=review

> Source/WebInspectorUI/ChangeLog:13
> +        (*): min-width: 0; min-height: 0; for all elements.

Putting this on "*" is a pretty heavy handed. We should make a targeted fix for the toolbar and start relying on the new default behavior instead of the old default behavior.

[Matt Baker]

Created attachment 262291 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 262291 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 262291

Committed r190436: <http://trac.webkit.org/changeset/190436>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.